Skip to content

[feat] Add GitHub Actions workflow for automated building and publishing #7

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Jun 1, 2025

Conversation

christian-byrne
Copy link
Contributor

Implements CI/CD pipeline that automatically builds the React extension and publishes to ComfyUI Registry on pushes to main. Also updates README with clear installation instructions that distinguish between registry installation and manual GitHub installation.

Fixes #1

Implements CI/CD pipeline that automatically builds React extension and publishes to ComfyUI Registry. Updates README with clear installation instructions distinguishing registry vs manual installation.
Updates workflow to trigger publishing only when pyproject.toml is modified, preventing unnecessary publishes on every main branch push. PRs will still build and test but won't publish.
Removes PR triggering since workflow is specifically for publishing. Now only runs when pyproject.toml is modified on main branch, making it more efficient and purposeful.
Adds 'includes = ["dist/"]' to pyproject.toml to ensure the built React extension is included when publishing to registry, since dist/ is normally ignored by comfy-cli due to .gitignore.
Uncomments dist/ in .gitignore since build artifacts shouldn't be committed to git. The GitHub Actions workflow will build fresh dist/ contents, and pyproject.toml includes config ensures it's included when publishing to registry.
@christian-byrne
Copy link
Contributor Author

christian-byrne commented Jun 1, 2025

@jtydhr88 Is there anything else needed to resolve #1?

@jtydhr88
Copy link
Contributor

jtydhr88 commented Jun 1, 2025

I think thats all we need

@christian-byrne christian-byrne merged commit 798a726 into main Jun 1, 2025
2 checks passed
@christian-byrne christian-byrne deleted the add-github-actions-workflow branch June 1, 2025 09:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

should ignore dist folder
2 participants