A couple of minor React tweaks#79
Open
alismith-dev wants to merge 2 commits into
Open
Conversation
Dedekind561
reviewed
Jan 27, 2023
Dedekind561
left a comment
Dedekind561
left a comment
Collaborator
There was a problem hiding this comment.
Mostly looks good - just one minor question
| const [exerciseIndex, setExerciseIndex] = useState(0); | ||
|
|
||
| function nextExercise() { | ||
| setExerciseIndex(exerciseIndex + 1); |
Collaborator
There was a problem hiding this comment.
Do you need to use an update callback here?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two small tweaks to the react branch:
useExercisehook to it's own fileBoth of these have come up on other branches I've been working on, and I figured I should just get them merged.