London | 26-SDC-March | Zobeir Rigi | Sprint 4 | Implement shell tools python#524
London | 26-SDC-March | Zobeir Rigi | Sprint 4 | Implement shell tools python#524Zobeir-Rigi wants to merge 10 commits into
Conversation
Zobeir-Rigi
added
the
Needs Review
LonMcGregor
left a comment
LonMcGregor
left a comment
There was a problem hiding this comment.
Good start, but there is some work left to do here.
Is there a package you could use to help with managing arguments? Right now it is a bit complex, and you can't combine single-letter arguments like the command line tools.
| elif arg != "-1": | ||
| path = arg | ||
|
|
||
| files = os.listdir(path) |
There was a problem hiding this comment.
Part of this task is to see if you can handle the listing yourself.
There was a problem hiding this comment.
Got it, added sorting to improve the listing.
| if arg == "-a": | ||
| show_all = True | ||
|
|
||
| elif arg != "-1": |
There was a problem hiding this comment.
Is there any difference between when -1 is used and when not?
There was a problem hiding this comment.
Thank you, there wasn’t any difference before. I’ve now handled -1 explicitly.
LonMcGregor
added
Reviewed
|
See my comments for the node.js version of this task - consider how to fully implement -1 and maybe use an argument parsing library |
Thanks — I’ve updated it to use argparse, which simplifies argument handling and supports combined flags |
LonMcGregor
left a comment
LonMcGregor
left a comment
There was a problem hiding this comment.
Good work. The main parts of this task are implemented and complete. If you want a stretch goal, you can take some extra time to conver the other parts to use argparse.
LonMcGregor
added
Complete
Great, I will do it as soon as I get some time. |
|
Closing PR because the SDC run has finished. Feel free to re-open if you're still working on it. |
3 participants
Self checklist