Cape Town |ITP-MAY-26|Enice Mutanda|Sprint 2| Coursework #1400
Open
Enice-Codes wants to merge 4 commits into
Open
Cape Town |ITP-MAY-26|Enice Mutanda|Sprint 2| Coursework #1400Enice-Codes wants to merge 4 commits into
Enice-Codes wants to merge 4 commits into
Conversation
This comment has been minimized.
This comment has been minimized.
5 similar comments
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Enice-Codes
added
Needs Review
This comment has been minimized.
This comment has been minimized.
github-actions
Bot
removed
the
Needs Review
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Enice-Codes
added
📅 Sprint 2
This comment has been minimized.
This comment has been minimized.
1 similar comment
This comment has been minimized.
This comment has been minimized.
github-actions
Bot
removed
the
Needs Review
Enice-Codes
added
the
Needs Review
cjyuan
reviewed
Jul 2, 2026
Comment on lines
11
to
+22
| console.log(`The result of multiplying 10 and 32 is ${multiply(10, 32)}`); | ||
|
|
||
| // =============> write your explanation here | ||
|
|
||
| // console.log prints out information it does not return any varable to its function.hence the syntax error. | ||
| // console.log cant read unprovided information. | ||
| // Finally, correct the code to fix the problem | ||
| // =============> write your new code here | ||
| function multiply (a,b){ | ||
| if (a===10 && b===32){ | ||
| let result =a * b ; | ||
| } | ||
| } No newline at end of file |
Contributor
There was a problem hiding this comment.
Have you tested your implementation to see if it can return the product of its parameters?
| // Use the MDN string documentation to help you find a solution | ||
| // This might help https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/String/toUpperCase | ||
|
|
||
| function touppersneakers (input){ |
Contributor
There was a problem hiding this comment.
Could you look up the naming conventions in JavaScript? In particular,
- Variable and function names
- Class and Types names
- Named constants
Then, update the function name according to those conventions.
Comment on lines
+18
to
+21
| function touppersneakers (input){ | ||
| return input.trim().replace(/\s+/g, "_").touppercase(); | ||
| } | ||
| console.log(touppersneakers("hello there"));//Hello There |
Contributor
There was a problem hiding this comment.
Have you tested your implementation to see if it works as expected?
Comment on lines
+10
to
+19
| function toSnakeCase(str) { | ||
| const pecestringwithouttrailingp = pencestring.substring(0,pencestring.length -1); | ||
| const padded penceNumberstring = pencestringWithoutTrailingP.padstart(3,"0"); | ||
| const pounds = paddedpenceNumberString.substring(0, paddedpencenumberstring.length-2); | ||
| const pencr= paddedpencenumberstring.substring(paddedpencenumberstring.length -2) | ||
| .padEnd(2,"0"); | ||
| return £${pounds}.${pence}`; | ||
| } | ||
| // test the function with different inputs | ||
| consloe.log(topounds("399p"), // £3.99 |
Contributor
There was a problem hiding this comment.
Have you tested this implementation?
| function formatAs12HourClock(time) { | ||
| const hours = Number(time.slice(0, 2)); | ||
| const minutes = time.slice(3, 5); | ||
| if (h) |
Comment on lines
18
to
22
| if (hours > 12) { | ||
| return `${hours - 12}:00 pm`; | ||
| return `${hours - 12}:${minutes} pm`; | ||
| } | ||
|
|
||
| return `${time} am`; |
Contributor
There was a problem hiding this comment.
The code looks correct.
Could you update the code so that the return values of formatAs12HourClock("01:23") and formatAs12HourClock("13:23") are formatted consistently?
cjyuan
added
Reviewed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Self Check
Changelist
Answered questions to all excerises
completed code
checked code on node
Used Dev tools as per an excercise