Skip to content

Glasgow | 26-ITP-May | Francesco Romano Monda | Sprint 1 | Complete Sprint 1 Coursework#1394

Open
fromonda wants to merge 5 commits into
CodeYourFuture:mainfrom
fromonda:coursework/sprint-1
Open

Glasgow | 26-ITP-May | Francesco Romano Monda | Sprint 1 | Complete Sprint 1 Coursework#1394
fromonda wants to merge 5 commits into
CodeYourFuture:mainfrom
fromonda:coursework/sprint-1

Conversation

@fromonda

@fromonda fromonda commented Jun 23, 2026

Copy link
Copy Markdown

Self checklist

  • I have titled my PR with Region | Cohort | FirstName LastName | Sprint | Assignment Title
  • My changes meet the requirements of the task
  • I have tested my changes
  • My changes follow the style guide

Changelist

  • Added explanation of line 3 and explained the = assignment operator to improve understanding of variable assignment in 1-count.js.
  • Fixed construction of the initials variable and generated initials dynamically using charAt(0) in 2-initials.js.
  • Added dir and ext variables in 3-path.js.
  • Added comments explaining how the Math.random() expression works and clarified that it generates a random integer between 1 and 100 (inclusive) using Math.floor() in 4-random-js.
  • Commented the instructions to prevent a SyntaxError in 0.js.
  • Explained that const variables cannot be reassigned in 1.js.
  • Explained the ReferenceError caused by using a variable before declaring it in 2.js.
  • Fixed the slice() error by using a string instead of a number in 3.js.
  • Explained that variable names cannot begin with a number in 4.js.

@fromonda fromonda added 📅 Sprint 1 Assigned during Sprint 1 of this module Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. Module-Structuring-And-Testing-Data The name of the module. labels Jun 23, 2026
@LonMcGregor LonMcGregor added the Review in progress This review is currently being reviewed. This label will be replaced by "Reviewed" soon. label Jun 29, 2026

@LonMcGregor LonMcGregor left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work so far on these tasks. Now you just need to work on the next parts, the errors and interpreting tasks in Sprint 1

@LonMcGregor LonMcGregor added Reviewed Volunteer to add when completing a review with trainee action still to take. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. Review in progress This review is currently being reviewed. This label will be replaced by "Reviewed" soon. labels Jun 29, 2026
@fromonda

Copy link
Copy Markdown
Author

Great work so far on these tasks. Now you just need to work on the next parts, the errors and interpreting tasks in Sprint 1
Thank you for your comment. However, I am a bit confused by your feedback. From my perspective, this task is complete, but based on the second part of your comment, I assume that you do not consider it complete.
If I have misunderstood your feedback, I will proceed with the Sprint 2 backlog. Otherwise, I would appreciate it if you could provide more specific guidance on what is still missing so I can address it accordingly.

@LonMcGregor

Copy link
Copy Markdown

@fromonda You've done part 1 of this sprint. If you look in the readme there are two other mandatory parts (2 - errors, 3 - interpret) and an optional stretch goal. All of these need to be completed within this PR. You can make changes and push and they will appear on this branch and then I can review them.

@fromonda

Copy link
Copy Markdown
Author

@fromonda You've done part 1 of this sprint. If you look in the readme there are two other mandatory parts (2 - errors, 3 - interpret) and an optional stretch goal. All of these need to be completed within this PR. You can make changes and push and they will appear on this branch and then I can review them.

It took me so long to complete the first part of this sprint that I mistakenly believed the task was finished after following only the instructions in the README file located in the root directory. I overlooked the guidance provided in the README file within each sprint folder. Thank you for pointing this out.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Module-Structuring-And-Testing-Data The name of the module. Reviewed Volunteer to add when completing a review with trainee action still to take. 📅 Sprint 1 Assigned during Sprint 1 of this module

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants