Glasgow | 26-ITP-May | Sandani Kannangara | Sprint 3 | Implement And Rewrite Tests#1374
Open
SandzSoft wants to merge 6 commits into
Open
Glasgow | 26-ITP-May | Sandani Kannangara | Sprint 3 | Implement And Rewrite Tests#1374SandzSoft wants to merge 6 commits into
SandzSoft wants to merge 6 commits into
Conversation
This comment has been minimized.
This comment has been minimized.
SandzSoft
changed the title
SandzSoft
added
📅 Sprint 3
cjyuan
reviewed
Jun 27, 2026
Comment on lines
+24
to
+36
| test("handles proper negative fractions", () => { | ||
| expect(isProperFraction(-4, 7)).toEqual(true); | ||
| expect(isProperFraction(4, -7)).toEqual(true); | ||
| }); | ||
|
|
||
| test("handles improper negative fractions", () => { | ||
| expect(isProperFraction(-7, 4)).toEqual(false); | ||
| expect(isProperFraction(7, -4)).toEqual(false); | ||
| }); | ||
|
|
||
| test("returns false when numerator equals denominator", () => { | ||
| expect(isProperFraction(4, 4)).toEqual(false); | ||
| }); |
Contributor
There was a problem hiding this comment.
Could also test cases with negative numerator and negative denominator.
cjyuan
added
Reviewed
SandzSoft
added
Needs Review
Contributor
|
Changes look good. |
cjyuan
added
Complete
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Self checklist
Changelist
Completed the "1-implement-and-rewrite-tests" section of Sprint 3.