-
-
Notifications
You must be signed in to change notification settings - Fork 386
London | 26-ITP-May | Zadri Abdule | Sprint 3 | Practice tdd #1370
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Zadri415
wants to merge
7
commits into
CodeYourFuture:main
Choose a base branch
from
Zadri415:sprint-3/practice-tdd
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
552bb4c
added Jest tests for countChar
Zadri415 5e4a23a
implemented getOrdinalNumber and added tests
Zadri415 2cdf11c
implemented repeatStr and added Jest tests
Zadri415 6ee1609
Add test for case-sensitive character counting
Zadri415 0ac1333
Add test for null and undefined string inputs
Zadri415 3d45d8a
Restrict input to integers in get-ordinal-number.js
Zadri415 54df026
Refactor tests for non-integer input handling
Zadri415 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,5 +1,50 @@ | ||
| /** | ||
| * countChar(stringOfCharacters, findCharacter) | ||
| * | ||
| * Count the number of times a single character appears in a string. | ||
| * | ||
| * Behaviour / contract: | ||
| * - The function is case-sensitive: 'a' ≠ 'A'. | ||
| * - `stringOfCharacters` may be `null` or `undefined`; in that case the function returns 0. | ||
| * - `findCharacter` is treated as a single character (a single Unicode code point). | ||
| * If you pass a longer string it will never match. | ||
| * | ||
| * Parameters: | ||
| * @param {string|null|undefined} stringOfCharacters - The string to search through. | ||
| * @param {string} findCharacter - The single character to count (should be length 1). | ||
| * | ||
| * Returns: | ||
| * @returns {number} The number of occurrences of `findCharacter` in `stringOfCharacters`. | ||
| * | ||
| * Throws: | ||
| * - Does not throw for `null`/`undefined` source; returns 0. | ||
| * - If you want stricter validation for types or for multi-character `findCharacter`, | ||
| * validate and throw in the implementation and update tests accordingly. | ||
| * | ||
| * Examples: | ||
| * // basic | ||
| * countChar('aaaaa', 'a'); // 5 | ||
| * countChar('Hello', 'l'); // 2 | ||
| * | ||
| * // empty/absent inputs | ||
| * countChar('', 'a'); // 0 | ||
| * countChar(null, 'a'); // 0 | ||
| * | ||
| * Notes: | ||
| * - Uses strict equality (===) so it matches exact code points. | ||
| * - For emoji or other characters outside the BMP this implementation (for..of) | ||
| * iterates code points, which handles many emoji correctly. | ||
| */ | ||
|
|
||
| function countChar(stringOfCharacters, findCharacter) { | ||
| return 5 | ||
| if (stringOfCharacters == null) return 0; | ||
| let count = 0; | ||
| for (const char of stringOfCharacters) { | ||
| if (char === findCharacter) { | ||
| count++; | ||
| } | ||
| } | ||
| return count; | ||
| } | ||
|
|
||
| module.exports = countChar; | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,5 +1,29 @@ | ||
| function getOrdinalNumber(num) { | ||
| return "1st"; | ||
| // Validate input: must be a number (not a string, null or undefined) and not NaN | ||
| if (typeof num !== "number" || Number.isNaN(num)) { | ||
| throw new TypeError("Input must be a number"); | ||
| } | ||
|
Comment on lines
+3
to
+5
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Note: A stricter check would be to ensure I don't think ordinal numbers apply to non-integers.
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Thanks for feedback. |
||
| // Strict: only allow integers | ||
| if (!Number.isInteger(num)) { | ||
| throw new TypeError("Input must be an integer"); | ||
| } | ||
|
|
||
| const abs = Math.abs(num); | ||
| const lastTwoDigits = abs % 100; | ||
| if (lastTwoDigits >= 11 && lastTwoDigits <= 13) { | ||
| return `${num}th`; | ||
| } | ||
| const lastDigit = lastTwoDigits % 10; | ||
| if (lastDigit === 1) { | ||
| return `${num}st`; | ||
| } | ||
| if (lastDigit === 2) { | ||
| return `${num}nd`; | ||
| } | ||
| if (lastDigit === 3) { | ||
| return `${num}rd`; | ||
| } | ||
| return `${num}th`; | ||
| } | ||
|
|
||
| module.exports = getOrdinalNumber; | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,7 +1,16 @@ | ||
| function repeatStr() { | ||
| // Your implementation of this function must *not* call String.prototype.repeat (https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/String/repeat). | ||
| // The goal is to re-implement that function, not to use it. | ||
| return "hellohellohello"; | ||
| function repeatStr(str, count) { | ||
| if (typeof str !== "string") { | ||
| throw new TypeError("First argument must be a string"); | ||
| } | ||
| if (!Number.isInteger(count) || count < 0) { | ||
| throw new TypeError("Count must be a non-negative integer"); | ||
| } | ||
|
|
||
| let result = ""; | ||
| for (let i = 0; i < count; i++) { | ||
| result += str; | ||
| } | ||
| return result; | ||
| } | ||
|
|
||
| module.exports = repeatStr; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If these behaviors are expected from the function, then in TDD we should prepare tests to ensure the function meet all these requirements, including