Skip to content

Conversation

@CodeWithDennis
Copy link
Owner

@CodeWithDennis CodeWithDennis commented Sep 10, 2025

Todos

  • Validation
    • Required
    • Max length
    • Min length

Known Issues

Markdown Fields (https://discord.com/channels/883083792112300104/1401108749623754852)

Filament\Forms\Components\RichEditor::{closure:Filament\Forms\Components\RichEditor::setUp():303}(): Argument #2 ($rawState) must be of type ?array, string given

@CodeWithDennis
Copy link
Owner Author

How should we handle hidden/visible,disabled? @dissto

@CodeWithDennis CodeWithDennis changed the title Can create record test Create record and create form validation tests Sep 10, 2025
@dissto
Copy link
Collaborator

dissto commented Sep 11, 2025

How should we handle hidden/visible,disabled? @dissto

For this given test it probably makes sense to just assert against "visible" fields? 🤔
I'd imagine we'd have accompanying tests for "visible", "hidden", "disabled" either way

@CodeWithDennis CodeWithDennis marked this pull request as ready for review September 18, 2025 12:39
@CodeWithDennis CodeWithDennis merged commit 5e55a97 into 4.x Sep 18, 2025
1 check passed
@CodeWithDennis CodeWithDennis deleted the can-create-record-test branch September 18, 2025 12:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants