Added Reformatting Guide #314
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
austincondiff
requested review from
0xWDG,
FastestMolasses,
KaiTheRedNinja,
avdept,
thecoolwinter and
tom-ludwig
…tions to show or hide it and change it's position.
austincondiff
force-pushed
the
feat/reformatting-guide
branch
from
66d2af9 to
9c0e465
Compare
Sources/CodeEditSourceEditor/CodeEditSourceEditor/CodeEditSourceEditor.swift
Show resolved
Hide resolved
Sources/CodeEditSourceEditor/Controller/TextViewController.swift
Outdated
Show resolved
Hide resolved
tom-ludwig
requested changes
Apr 26, 2025
Member
tom-ludwig
left a comment
tom-ludwig
left a comment
There was a problem hiding this comment.
Just a few tips for improving the comments — other than that, great changes!
Sources/CodeEditSourceEditor/Controller/TextViewController+LoadView.swift
Outdated
Show resolved
Hide resolved
Sources/CodeEditSourceEditor/ReformattingGuide/ReformattingGuideView.swift
Show resolved
Hide resolved
Collaborator
Author
|
This is ready for review. I've fixed tests, SwiftLint issues, and resolved issues raised. |
Member
|
Would this close #207? |
Collaborator
Author
|
No, invisible characters are completely different. They look like this:
|
Member
|
Oops I made a typo i meant #270 of course 😆 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This will add a reformatting guide that is disabled by default. When enabled users will see a line drawn at a configurable column to guide them as to when and how they should reformat their code.
Related Issues
Checklist
Screenshots