Skip to content

Conversation

@thecoolwinter
Copy link
Collaborator

Description

Fixes a crash that occurred when editing the last characters in a file. This was missed by tests because it only appeared when syntax highlighting was applied.

Added a test case that catches this case in the styled range store. Added a second test in the highlighter tests that catches this and hopefully helps prevent some future bugs related to the highlighter.

Also added the package tests to the example app so tests can be run from the example project.

Related Issues

Checklist

  • I read and understood the contributing guide as well as the code of conduct
  • The issues this PR addresses are related to each other
  • My changes generate no new warnings
  • My code builds and runs on my machine
  • My changes are all related to the related issue above
  • I documented my code

Screenshots

N/A

@thecoolwinter thecoolwinter self-assigned this Jan 6, 2025
@thecoolwinter thecoolwinter added the bug Something isn't working label Jan 6, 2025
@thecoolwinter thecoolwinter merged commit 63bae5a into CodeEditApp:main Jan 7, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants