Added two new components, PivotNoBootstrap and PivotTableNoBootstrap #2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added two new components, PivotNoBootstrap and PivotTableNoBootstrap which the main reason is not to depend on bootstrap, so the main changes were the classes and css. Added in the App.vue one example and imports in that file and browser.js.
Contributor
|
Thanks for your PR and sorry for taking a year to respond... I agree this component should be usable with other css frameworks, but duplicating code isn't the best solution in my opinion. If you have suggestions please write them in this issue #11 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The main reason is not to depend on bootstrap, so the main changes were the classes and css. Added in the App.vue one example and imports in that file and browser.js.
I did not reuse the code and refactor any of it. This is because if you do not want to accept, I will need this component up and running on my on and fast.
In my project I can't use bootstrap and any of bootstrap css, so this is some workaround it.
If you want, I could refactor in some mixins or some smaller components, and also reuse some of the duplicated css. It's your call to accept this PR or not.
Great work btw. Helped me a lot!
Note: I changed the styles a bit to look like Atlassian AUI Tables and Atlassian AUI Buttons.