[minor_change] Add module aci_port_channel_member_policy to manage port channel member policies (DCNE-310) #762
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akinross
requested review from
anvitha-jain,
gmicol,
lhercot,
sajagana,
samiib and
shrsr
as code owners
github-actions
bot
changed the title
…rt channel member policies
akinross
force-pushed
the
732_port_channel_member_policy
branch
from
c7cd2d4 to
cea8f5d
Compare
sajagana
requested changes
May 19, 2025
tests/integration/targets/aci_port_channel_member_policy/tasks/main.yml
Outdated
Show resolved
Hide resolved
samiib
requested changes
May 20, 2025
| description: | ||
| - The priority of the Port Channel Member policy. | ||
| - The APIC defaults to C(32768) when not provided. | ||
| - The allowed minimum is C(1) and the allowed maximum is C(65535). |
There was a problem hiding this comment.
I've seen a few different ways to describe a valid range in the ansible-aci collection. There is only one other example like this. Should we use a description that matches most other modules?
Suggested change
| - The allowed minimum is C(1) and the allowed maximum is C(65535). | |
| - Accepted values range between C(1) and C(65535). |
lhercot
requested changes
May 23, 2025
…y_port_channel_member
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #732