Addition of aci_l4l7_policy_based_redirect and related modules (DCNE-391) #751
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shrsr
requested review from
akinross,
anvitha-jain,
gmicol,
lhercot,
sajagana and
samiib
as code owners
github-actions
bot
changed the title
akinross
requested changes
Apr 25, 2025
gmicol
requested changes
May 2, 2025
|
importer failures, please check |
samiib
requested changes
May 9, 2025
| max_threshold: | ||
| description: | ||
| - The maximum percent when threshold is enabled. | ||
| - The APIC defaults to C(0) when unset during creation. |
There was a problem hiding this comment.
Should we also note the valid range here, 0-100%?
| - cisco.aci.aci | ||
| - cisco.aci.annotation | ||
| - cisco.aci.owner | ||
| notes: |
There was a problem hiding this comment.
Shouldn't the ip_sla_monitor_policy also exist before using?
There was a problem hiding this comment.
We only mention the required attributes or the parent object/top object in the notes section
| if state == "present": | ||
| child_configs = [] | ||
| if ip_sla_monitor_policy: | ||
| monitor_tdn = "uni/tn-{0}/ipslaMonitoringPol-{1}".format(tenant, ip_sla_monitor_policy) |
There was a problem hiding this comment.
Is it possible to add an IPSLA monitoring policy from a different tenant? I presume not, but thought of double checking.
| - cisco.aci.aci | ||
| - cisco.aci.annotation | ||
| notes: | ||
| - The I(tenant), I(device), I(concrete_device), I(concrete_interface) and I(policy) must exist before using this module in your playbook. |
There was a problem hiding this comment.
Is health_group also an object we need to mention here?
There was a problem hiding this comment.
It's a child of vnsSvcRedirectPol so there's no need to mention it here
| check_mode: true | ||
| register: add_health_group_cm | ||
|
|
||
| - name: Add a new Redirect Health Group in check mode |
There was a problem hiding this comment.
Suggested change
| - name: Add a new Redirect Health Group in check mode | |
| - name: Add a new Redirect Health Group |
| - "'uni/tn-ansible_tenant/svcCont/redirectHealthGroup-ansible_health_group_2' in query_all.current | map(attribute='vnsRedirectHealthGroup.attributes.dn') | list" | ||
|
|
||
| # REMOVE L4-L7 HEALTH GROUP | ||
| - name: Remove Redirect Health Group |
There was a problem hiding this comment.
Suggested change
| - name: Remove Redirect Health Group | |
| - name: Remove Redirect Health Group in check mode |
samiib
requested changes
May 9, 2025
| - cisco.aci.annotation | ||
| - cisco.aci.owner | ||
| notes: | ||
| - The I(tenant) must exist before using this module in your playbook. |
There was a problem hiding this comment.
Suggested change
| - The I(tenant) must exist before using this module in your playbook. | |
| - The O(tenant) must exist before using this module in your playbook. |
There was a problem hiding this comment.
Same comment as made on the related PR
sajagana
reviewed
May 23, 2025
| - module: cisco.aci.aci_l4l7_concrete_interface | ||
| - module: cisco.aci.aci_l4l7_policy_based_redirect | ||
| - name: APIC Management Information Model reference | ||
| description: More information about the internal APIC class B(vns:RedirectDest) |
There was a problem hiding this comment.
Suggested change
| description: More information about the internal APIC class B(vns:RedirectDest) | |
| description: More information about the internal APIC class B(vns:RedirectDest), B(vns:L1L2RedirectDest) |
…s with changed names
…nitor_policy attribute
…olicy_based_redirect modules
…l7_policy_based_redirect_destination
shrsr
dismissed stale reviews from gmicol, lhercot, akinross, anvitha-jain, sajagana, and samiib
via
5b48277
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains completed aci_l4l7_policy_based_redirect and related modules from #186