Skip to content

feat: Add support to specify path #68

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from

Conversation

myakove
Copy link

@myakove myakove commented May 24, 2025

Support set cloudflare.tunnel.2.path: "/my_path" when creating hostname.

Support set `cloudflare.tunnel.2.path: "/my_path"` when creating
hostname.
@myakove
Copy link
Author

myakove commented May 24, 2025

Most of the changes was made by ruff, I hope it's OK.
I can push a PR only with ruff changes and rebase my PR on it if needed.
I can add .pre-commit to have unified format for the python code.

@ChrispyBacon-dev
Copy link
Owner

I'm currently completely rewriting the code as the main file is too long and badly organized. I leave the PR open.

@myakove
Copy link
Author

myakove commented May 24, 2025

Make sense, you can take my changes (it's only few lines) and add it to your refactor PR.
It's only sent path to Cloudflare API (like service and hostname are sent)

Also my PR do not add path to the UI (I don;t know how to :) )

@ChrispyBacon-dev
Copy link
Owner

closing this PR, I added support for path and service types. currently in unstable branch already fully tested but I'm experimenting with another function before I push it to stable branch. you can already test it with docker image tag unstable.

@myakove
Copy link
Author

myakove commented May 28, 2025

Thank you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants