fix: get attestation block head#9500
Draft
twoeths wants to merge 1 commit into
Draft
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request refactors the fork-choice logic to resolve the specific payload-status variant (PENDING, EMPTY, or FULL) that an attestation votes for based on its slot and index, introducing the getAttestationHeadBlock helper. This helper is integrated into the gossip validation path for attestations and aggregates. The reviewer identified a critical issue in the error handling within verifyHeadBlockIsKnown: catching all errors and throwing a REJECT action is incorrect when the error is ATTESTS_TO_FUTURE_BLOCK, which should instead trigger an IGNORE action. A code suggestion was provided to properly differentiate these error cases.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
Comment on lines
+783
to
+791
| let headBlock: ProtoBlock | null; | ||
| try { | ||
| headBlock = chain.forkChoice.getAttestationHeadBlock(toRootHex(beaconBlockRoot), attestationSlot, index); | ||
| } catch (_e) { | ||
| throw new AttestationError(GossipAction.REJECT, { | ||
| code: AttestationErrorCode.INVALID_PAYLOAD_STATUS_VALUE, | ||
| attDataIndex: index, | ||
| }); | ||
| } |
Contributor
There was a problem hiding this comment.
Catching all errors from getAttestationHeadBlock and blindly throwing INVALID_PAYLOAD_STATUS_VALUE with GossipAction.REJECT is problematic. If the error thrown is ATTESTS_TO_FUTURE_BLOCK (e.g., when attestationSlot < headBlock.slot), the attestation is attesting to a future block. According to the gossip validation rules, such attestations should not be considered (i.e., GossipAction.IGNORE), rather than being rejected as having an invalid payload status value.
We should inspect the caught error and handle ATTESTS_TO_FUTURE_BLOCK separately (e.g., by throwing an AttestationError with GossipAction.IGNORE and an appropriate error code like UNKNOWN_OR_PREFINALIZED_BEACON_BLOCK_ROOT or similar).
Suggested change
| let headBlock: ProtoBlock | null; | |
| try { | |
| headBlock = chain.forkChoice.getAttestationHeadBlock(toRootHex(beaconBlockRoot), attestationSlot, index); | |
| } catch (_e) { | |
| throw new AttestationError(GossipAction.REJECT, { | |
| code: AttestationErrorCode.INVALID_PAYLOAD_STATUS_VALUE, | |
| attDataIndex: index, | |
| }); | |
| } | |
| let headBlock: ProtoBlock | null; | |
| try { | |
| headBlock = chain.forkChoice.getAttestationHeadBlock(toRootHex(beaconBlockRoot), attestationSlot, index); | |
| } catch (e) { | |
| if (e && typeof e === "object" && "err" in e && (e as any).err?.code === "ATTESTS_TO_FUTURE_BLOCK") { | |
| throw new AttestationError(GossipAction.IGNORE, { | |
| code: AttestationErrorCode.UNKNOWN_OR_PREFINALIZED_BEACON_BLOCK_ROOT, | |
| root: toRootHex(beaconBlockRoot), | |
| }); | |
| } | |
| throw new AttestationError(GossipAction.REJECT, { | |
| code: AttestationErrorCode.INVALID_PAYLOAD_STATUS_VALUE, | |
| attDataIndex: index, | |
| }); | |
| } |
Contributor
Performance Report🚀🚀 Significant benchmark improvement detected
Full benchmark results
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
verifyHeadBlockIsKnown()is always with default statusDescription
forkchoice. getAttestationHeadBlock()getAttestationPayloadStatus()AI Assistance Disclosure