Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR aims to fix type/behavior mismatches in Discord user context commands where the selected “member” argument can be a discord.User (e.g., when the target has left the server), aligning with the issue described in #736 and extending the approach to other commands.
Changes:
- Update user-context-command parameter types to accept
discord.Member | discord.User. - Refactor induction and applicant flows to pass user IDs into internal helpers and re-resolve to
discord.Membervia the main guild before accessing member-only fields (like.roles). - Simplify the “make applicant from message author” path by reusing the shared helper logic.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
cogs/strike.py |
Expands strike context-command typings to allow discord.User (but currently still has a crash path when the target isn’t a guild member). |
cogs/make_applicant.py |
Changes internal helper to accept an ID and validates membership via main_guild.get_member(...) before role operations. |
cogs/induct.py |
Changes internal helper to accept an ID and validates membership via main_guild.get_member(...) before role operations. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
CarrotManMatt
approved these changes
Mar 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rectifies the issue identified in #736 for all other user_commands.
Must be merged after #736