When testing a cycle event, calling application_impl::stop_offer_event is invalid. #945
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
duartenfonseca
force-pushed
the
cycle_event_fix_test
branch
from
a04da95 to
1619df5
Compare
duartenfonseca
changed the title
…t is invalid. If an app offers an event that is configured as cyclic, and after notifying, it calls stop_offer_event, the event keeps running the notifying cycle, which can be seen by adding a log to `event::notify` This stops that cycle. Signed-off-by: hjkcst <[email protected]>
duartenfonseca
force-pushed
the
cycle_event_fix_test
branch
from
1619df5 to
85677c8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If an app offers an event that is configured as cyclic, and after notifying,
it calls stop_offer_event, the event keeps running the notifying cycle,
which can be seen by adding a log to
event::notifyThis stops that cycle.
#694 was stale, and this changes were important, so this PR was created with
our proposal.
it fixes #666