Added multicast socket error handling #895
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Added error handling for "leave multicast group". Even if set_options fail we will clear corresponding data and close socket; - Corrected pass trough errno to boost error object. Co-authored-by: Matthew Russell <[email protected]>
kheaactua
force-pushed
the
no_vendor_tce_after_resume_from_str
branch
from
401aa35 to
034935a
Compare
Resolving rebase onto 25fbd6f
Collaborator
|
not needed anymore with latest netlink changes |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
set_optionsfail we will clear corresponding data and close socket;setsockopt()returns-1on failure anderrnois written to to indicate the error. In the original code first argument to thesys::error_code::assign()will use-1, while it should useerrno.errnoto boost error object.