Code Quality: Address shadowing #840
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
kheaactua
commented
Jan 28, 2025
kheaactua
commented
- Addresses most shadowing variables
- Fixes some old style C-casts
goncaloalmeida
approved these changes
Feb 12, 2025
kheaactua
force-pushed
the
shadowing
branch
3 times, most recently
from
fb06964 to
7e6e3a1
Compare
implementation/endpoints/src/local_tcp_server_endpoint_impl.cpp
Outdated
Show resolved
Hide resolved
implementation/endpoints/src/local_tcp_server_endpoint_impl.cpp
Outdated
Show resolved
Hide resolved
implementation/endpoints/src/local_uds_server_endpoint_impl.cpp
Outdated
Show resolved
Hide resolved
implementation/endpoints/src/local_tcp_server_endpoint_impl.cpp
Outdated
Show resolved
Hide resolved
implementation/endpoints/src/local_uds_server_endpoint_impl.cpp
Outdated
Show resolved
Hide resolved
implementation/endpoints/src/local_uds_server_endpoint_impl.cpp
Outdated
Show resolved
Hide resolved
duartenfonseca
force-pushed
the
shadowing
branch
from
33eab86 to
4ded382
Compare
Swapped to a static_cast
Swapped to a static_cast
Switched to scoped_lock
Switched to scoped_lock
Switched to scoped_lock
…wing Switched to scoped_lock
…s shadowing Switched to scoped_lock
… Address shadowing Switched to scoped_lock
…uality: Address shadowing Switched to scoped_lock
…! Code Quality: Address shadowing Removed redundant converters
…! fixup! Code Quality: Address shadowing
…up! fixup! fixup! fixup! Code Quality: Address shadowing Removed explicit template from scoped_lock in files already changed in this commit
…up! fixup! fixup! fixup! fixup! Code Quality: Address shadowing
…up! fixup! fixup! fixup! fixup! fixup! Code Quality: Address shadowing Implemented structured binding
…up! fixup! fixup! fixup! fixup! fixup! fixup! Code Quality: Address shadowing Implemented Duarte's suggestion
…up! fixup! fixup! fixup! fixup! fixup! fixup! fixup! Code Quality: Address shadowing Another structured binding
…up! fixup! fixup! fixup! fixup! fixup! fixup! fixup! fixup! Code Quality: Address shadowing Consolodating duplicate branches
…sh! fixup! fixup! fixup! fixup! fixup! fixup! fixup! fixup! fixup! Code Quality: Address shadowing
…p! squash! fixup! fixup! fixup! fixup! fixup! fixup! fixup! fixup! fixup! Code Quality: Address shadowing
…h! fixup! squash! fixup! fixup! fixup! fixup! fixup! fixup! fixup! fixup! fixup! Code Quality: Address shadowing
…h! squash! fixup! squash! fixup! fixup! fixup! fixup! fixup! fixup! fixup! fixup! fixup! Code Quality: Address shadowing This was accidentally rebased out
duartenfonseca
pushed a commit
that referenced
this pull request
Aug 18, 2025
Changes: Add .git-blame-ignore-revs misc: format codebase Revert cmake refactor udp_server_endpoint_impl refactoring clear multicast only for last subscriber Ensure that a broken connection is forwarded to the app Fix connection drop routing to server fixing changes from cmakelists update Change order of local endpoint clean-up Fix increase in exported symbols Update security offer rule for messages plugin: remove load_plugins endpoints: fix use of bound client Code Quality: Address shadowing (#840) check routing ready on options_condition predicate Adapt new netlink test code to current boost.asio API emi: assign name to multicast worker thread Adapt new code to current boost.asio API Updates vsomeip config doc NetLink changes fix offer_stop_offer_test Testing local tcp communication with fault injection Rename IPV3 to IPV4 rmi: improve logging Ensure client process only once the registration Always send initial event on subscription Modernize CMake code (#734) rmc: drop use of netlink set TCP_USER_TIMEOUT on boardnet connections Use current boost.asio API vsomeip examples on Windows not running Fix vsomeip unit-tests failing on Windows Adding missing flag lse: fix missing timeout handling Disconnect on error Set was_not_connected to true if not connected Client specific debouncing by name Add predicate to condition variables Ensure to unsubscribe non selective events Handle not_socket error on send_cbk Remove the exponential timer increase from connection add logs to register subscription handlers tse: minor logging improvement Ensure tracing is done after the actual action Add stdint import for GCC 15 (#890) rm: fix client registration thread names make client id show as hex value replace with remove_known_client allow to set any service/instance on supress missing events rms: fix SIGSEGV on application register misc: remove ERROR_INFO Add extra documentation for routing info command Test for registration process network test for availability handler fix test false positives Valgrind memcheck corrections Enable valgrinds and helgrind removal set TCP_USER_TIMEOUT on local connections Removes access member sec rule from received responses
Merged
duartenfonseca
pushed a commit
that referenced
this pull request
Aug 18, 2025
Changes: Add .git-blame-ignore-revs misc: format codebase Revert cmake refactor udp_server_endpoint_impl refactoring clear multicast only for last subscriber Ensure that a broken connection is forwarded to the app Fix connection drop routing to server fixing changes from cmakelists update Change order of local endpoint clean-up Fix increase in exported symbols Update security offer rule for messages plugin: remove load_plugins endpoints: fix use of bound client Code Quality: Address shadowing (#840) check routing ready on options_condition predicate Adapt new netlink test code to current boost.asio API emi: assign name to multicast worker thread Adapt new code to current boost.asio API Updates vsomeip config doc NetLink changes fix offer_stop_offer_test Testing local tcp communication with fault injection Rename IPV3 to IPV4 rmi: improve logging Ensure client process only once the registration Always send initial event on subscription Modernize CMake code (#734) rmc: drop use of netlink set TCP_USER_TIMEOUT on boardnet connections Use current boost.asio API vsomeip examples on Windows not running Fix vsomeip unit-tests failing on Windows Adding missing flag lse: fix missing timeout handling Disconnect on error Set was_not_connected to true if not connected Client specific debouncing by name Add predicate to condition variables Ensure to unsubscribe non selective events Handle not_socket error on send_cbk Remove the exponential timer increase from connection add logs to register subscription handlers tse: minor logging improvement Ensure tracing is done after the actual action Add stdint import for GCC 15 (#890) rm: fix client registration thread names make client id show as hex value replace with remove_known_client allow to set any service/instance on supress missing events rms: fix SIGSEGV on application register misc: remove ERROR_INFO Add extra documentation for routing info command Test for registration process network test for availability handler fix test false positives Valgrind memcheck corrections Enable valgrinds and helgrind removal set TCP_USER_TIMEOUT on local connections Removes access member sec rule from received responses
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.