-
Notifications
You must be signed in to change notification settings - Fork 766
Client does not go back to initial Wait Phase when offer service TTL expires #804
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Client does not go back to initial Waiting Phase when offer service TTL expires
Client does not go back to initial Waiting Phase when offer service TTL expires
implementation/service_discovery/src/service_discovery_impl.cpp
Outdated
Show resolved
Hide resolved
Collaborator
|
@chw-eng still testing this PR. can you do this tiny change i asked? |
Co-authored-by: Duarte Fonseca <[email protected]>
Contributor
Author
done |
Collaborator
|
@chw-eng can you fix the conflict? thanks |
Contributor
Author
|
@duartenfonseca done |
implementation/service_discovery/src/service_discovery_impl.cpp
Outdated
Show resolved
Hide resolved
vvcarvalho-csw
pushed a commit
to vvcarvalho-csw/vsomeip
that referenced
this pull request
Nov 10, 2025
Client not entering initial Wait Phase when offer service TTL expires According to SOMEIP/SD Protocol Spec, Client should go to "Initial Wait Phase" when TTL expires and start to send "find service". This changes the behaviour COVESA#804
Co-authored-by: Duarte Fonseca <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is to fix bug reported in
#803