Skip to content

Conversation

@gierdo
Copy link
Contributor

@gierdo gierdo commented Nov 22, 2025

This MR proposes the unification of dependency / build / venv management using uv.

It is built on top of the state of #153. I will keep it synchronized until it has been merged.

The MR should be reviewed against that state / after it has been merged.

@gierdo gierdo force-pushed the uv-dependency-management branch 3 times, most recently from 8eeaeb1 to 73dbb7b Compare November 22, 2025 10:24
@gierdo
Copy link
Contributor Author

gierdo commented Nov 22, 2025

The pyproject.toml and uv integration provides powerful and concise integration with formatters and linters / typecheckers etc.

What is your opinion on those?

I would like to propose throwing at least ruff and maybe a typechecker at it, enforcing a common set of rules for style + formatting and more confidence in quality.

If you are interested, I'll add an additional MR after this.

@gierdo gierdo force-pushed the uv-dependency-management branch 4 times, most recently from 9b369de to 7b94433 Compare November 22, 2025 11:09
@gunnar-mb
Copy link
Collaborator

Great, thanks. I will take a look soon. 153 is merged and I had to add back a reference to the submodule (because changing .gitmodules file is not enough - submodules are a bit strange), so this needs a rebase now.

@gunnar-mb
Copy link
Collaborator

I would like to propose throwing at least ruff and maybe a typechecker at it, enforcing a common set of rules for style + formatting and more confidence in quality.

I had ruff, and black and some other things on a branch. Guess I never finished it. But I recall there were a few areas where I preferred keeping the code style (maybe longer lines, or something like it), but mostly I'm fine with it, so yes I'm happy to pick up the thread and look at it again.

@gunnar-mb
Copy link
Collaborator

Also, since you are looking at fixing the dependency tree anyway, feel free to see if these changes make sense, just to get rid of the complaint: https://github.com/COVESA/ifex/security/dependabot

@gierdo
Copy link
Contributor Author

gierdo commented Nov 26, 2025

I would like to propose throwing at least ruff and maybe a typechecker at it, enforcing a common set of rules for style + formatting and more confidence in quality.

I had ruff, and black and some other things on a branch. Guess I never finished it. But I recall there were a few areas where I preferred keeping the code style (maybe longer lines, or something like it), but mostly I'm fine with it, so yes I'm happy to pick up the thread and look at it again.

The configuration can be adapted, excluding / changing a few rules selectively, e.g. line length etc. I think we could find a good convention/configuration.

@gierdo gierdo force-pushed the uv-dependency-management branch from 7b94433 to ee53c02 Compare November 26, 2025 12:52
@gierdo
Copy link
Contributor Author

gierdo commented Nov 26, 2025

I would like to propose throwing at least ruff and maybe a typechecker at it, enforcing a common set of rules for style + formatting and more confidence in quality.

I had ruff, and black and some other things on a branch. Guess I never finished it. But I recall there were a few areas where I preferred keeping the code style (maybe longer lines, or something like it), but mostly I'm fine with it, so yes I'm happy to pick up the thread and look at it again.

I will create a separate MR for discussion of that, based on the uv branch.

@gierdo
Copy link
Contributor Author

gierdo commented Nov 27, 2025

Also, since you are looking at fixing the dependency tree anyway, feel free to see if these changes make sense, just to get rid of the complaint: https://github.com/COVESA/ifex/security/dependabot

I don't have access to the dependabot complaints, but I assume that whatever dependabot complains about would be fixed by pulling up the dependencies ;)
I created a fresh lock file of the dependency graph, anyways. pysentry-rs gives me no warnings, I assume dependabot should be reasonably happy.

@gunnar-mb
Copy link
Collaborator

I don't have access to the dependabot complaints

Oh!

but I assume that whatever dependabot complains about would be fixed by pulling up the dependencies ;)

Yes probably, and they are minor things but I clicked to create the PRs now anyway just so you can see.

@gierdo
Copy link
Contributor Author

gierdo commented Nov 27, 2025

I don't have access to the dependabot complaints

Oh!

but I assume that whatever dependabot complains about would be fixed by pulling up the dependencies ;)

Yes probably, and they are minor things but I clicked to create the PRs now anyway just so you can see.

Ah, excellent. Yes, updating the dependency graph in the uv lock appears to have resolved eventual complaints with regards to python dependencies, it's only a bump for the document generation. I can cherry-pick the proposed change in here, as well, but the change proposed by dependabot doesn't seem unreasonable and could also be handled in the PR you opened up directly.

Edit: Now I read your comment, will try to address it there.

@gunnar-mb
Copy link
Collaborator

Whatever is easiest - cherry pick could be easier so you can test the combined result. I just put the PR up for your info.

@gierdo
Copy link
Contributor Author

gierdo commented Nov 27, 2025

Whatever is easiest - cherry pick could be easier so you can test the combined result. I just put the PR up for your info.

Alright, I'll cherry-pick the fixed dependencies from #157 here.

gierdo and others added 3 commits November 27, 2025 12:12
- Consolidate runtime and dev dependencies
- Remove pipfile, tox.ini, requirements*.txt
- Replace pyenv and venv activation with uv run

Signed-off-by: Dominikus Gierlach <[email protected]>
Bumps [vite](https://github.com/vitejs/vite/tree/HEAD/packages/vite) from 5.4.20 to 5.4.21.
- [Release notes](https://github.com/vitejs/vite/releases)
- [Changelog](https://github.com/vitejs/vite/blob/v5.4.21/packages/vite/CHANGELOG.md)
- [Commits](https://github.com/vitejs/vite/commits/v5.4.21/packages/vite)

---
updated-dependencies:
- dependency-name: vite
  dependency-version: 5.4.21
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <[email protected]>
Signed-off-by: Dominikus Gierlach <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants