-
Notifications
You must be signed in to change notification settings - Fork 20
Uv dependency management #154
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
8eeaeb1 to
73dbb7b
Compare
|
The What is your opinion on those? I would like to propose throwing at least If you are interested, I'll add an additional MR after this. |
9b369de to
7b94433
Compare
|
Great, thanks. I will take a look soon. 153 is merged and I had to add back a reference to the submodule (because changing .gitmodules file is not enough - submodules are a bit strange), so this needs a rebase now. |
I had ruff, and black and some other things on a branch. Guess I never finished it. But I recall there were a few areas where I preferred keeping the code style (maybe longer lines, or something like it), but mostly I'm fine with it, so yes I'm happy to pick up the thread and look at it again. |
|
Also, since you are looking at fixing the dependency tree anyway, feel free to see if these changes make sense, just to get rid of the complaint: https://github.com/COVESA/ifex/security/dependabot |
The configuration can be adapted, excluding / changing a few rules selectively, e.g. line length etc. I think we could find a good convention/configuration. |
7b94433 to
ee53c02
Compare
I will create a separate MR for discussion of that, based on the uv branch. |
I don't have access to the dependabot complaints, but I assume that whatever dependabot complains about would be fixed by pulling up the dependencies ;) |
Oh!
Yes probably, and they are minor things but I clicked to create the PRs now anyway just so you can see. |
Ah, excellent. Yes, updating the dependency graph in the uv lock appears to have resolved eventual complaints with regards to python dependencies, it's only a bump for the document generation. I can cherry-pick the proposed change in here, as well, but the change proposed by dependabot doesn't seem unreasonable and could also be handled in the PR you opened up directly. Edit: Now I read your comment, will try to address it there. |
|
Whatever is easiest - cherry pick could be easier so you can test the combined result. I just put the PR up for your info. |
Alright, I'll cherry-pick the fixed dependencies from #157 here. |
- Consolidate runtime and dev dependencies - Remove pipfile, tox.ini, requirements*.txt - Replace pyenv and venv activation with uv run Signed-off-by: Dominikus Gierlach <[email protected]>
Bumps [vite](https://github.com/vitejs/vite/tree/HEAD/packages/vite) from 5.4.20 to 5.4.21. - [Release notes](https://github.com/vitejs/vite/releases) - [Changelog](https://github.com/vitejs/vite/blob/v5.4.21/packages/vite/CHANGELOG.md) - [Commits](https://github.com/vitejs/vite/commits/v5.4.21/packages/vite) --- updated-dependencies: - dependency-name: vite dependency-version: 5.4.21 dependency-type: indirect ... Signed-off-by: dependabot[bot] <[email protected]>
Signed-off-by: Dominikus Gierlach <[email protected]>
05e9428 to
4203374
Compare
This MR proposes the unification of dependency / build / venv management using uv.
It is built on top of the state of #153. I will keep it synchronized until it has been merged.
The MR should be reviewed against that state / after it has been merged.