Skip to content

Conversation

@nayakned
Copy link
Collaborator

@nayakned nayakned commented Oct 6, 2025

No description provided.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR inlines all getter/setter functions for the ACF CAN format by converting them from separate C function implementations to static inline functions defined in the header files. This is a performance optimization that eliminates function call overhead for field access operations.

  • Removed function implementations from source files and replaced with static inline definitions in headers
  • Moved field descriptor tables from source files to headers to support inline functionality
  • Added necessary include statements and macros to support the inlined implementations

Reviewed Changes

Copilot reviewed 6 out of 6 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
src/avtp/acf/CanBrief.c Removed all getter/setter function implementations and field descriptor table
src/avtp/acf/Can.c Removed all getter/setter function implementations and field descriptor table
src/avtp/acf/AcfCommon.c Entire file deleted as all functions moved to inline implementations
include/avtp/acf/CanBrief.h Added inline implementations of all getters/setters and field descriptor table
include/avtp/acf/Can.h Added inline implementations of all getters/setters and field descriptor table
include/avtp/acf/AcfCommon.h Added inline implementations of all getters/setters and field descriptor table

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@nayakned nayakned requested a review from Copilot October 26, 2025 07:42
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Copilot reviewed 25 out of 25 changed files in this pull request and generated 4 comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

#pragma once

#include <stdint.h>
#include <string.h>
Copy link

Copilot AI Oct 26, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The header file previously included <stdint.h> but now includes <string.h> instead. This changes the set of available standard types. Ensure <stdint.h> is included if integer types like uint8_t are needed, or confirm they are available through other includes.

Suggested change
#include <string.h>
#include <string.h>
#include <stdint.h>

Copilot uses AI. Check for mistakes.
Signed-off-by: Naresh Nayak <[email protected]>
@nayakned nayakned changed the title Inlined all getters/setters of the ACF CAN format. Inlined all getters/setters of the ACF data format. Oct 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant