Don't split printf if %s is static #960
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is part of my work on HipScript, where I use this project to run HIP code in the browser with WebGPU.
Using
printf
with the%s
specifier, like in__assert_fail
, causes chipStar to split the call into several. For example:This causes problems if multiple threads are printing, since these calls can interleave, producing output like:
This PR will keep
%s
specifiers, but only if the argument can be converted to a global string. In my case, where I compile to Vulkan afterwards with Clspv, this allows the compiler to convert the string pointer to an integer ID.