Skip to content

DRYify Map And Forecast Functions #71

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
O957 merged 11 commits into from
Dec 9, 2025
Merged

DRYify Map And Forecast Functions #71

Show file tree
Hide file tree
Changes from 4 commits
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
84f35e6
attempt to dryify code
O957 Dec 5, 2025
1c7f930
Merge remote-tracking branch 'origin/main' into 70-dryify-get_map_dat…
O957 Dec 5, 2025
98b3366
update function description
O957 Dec 5, 2025
dd1eb1a
attempt to try review comments
O957 Dec 5, 2025
cd7f618
make return statements explicit; change param order; update params; a…
O957 Dec 8, 2025
8eb52f7
run devtools document
O957 Dec 8, 2025
a44339f
Merge remote-tracking branch 'origin/main' into 70-dryify-get_map_dat…
O957 Dec 8, 2025
ec67674
Merge remote-tracking branch 'origin/main' into 70-dryify-get_map_dat…
O957 Dec 9, 2025
6391947
add dhm suggested edits
O957 Dec 9, 2025
a7cb9cb
typos edit
O957 Dec 9, 2025
56aa356
run devtools document
O957 Dec 9, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion DESCRIPTION
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ Description: This package provides functions to help with the maintenance of CDC
License: Apache License (>= 2)
Encoding: UTF-8
Roxygen: list(markdown = TRUE)
RoxygenNote: 7.3.2
RoxygenNote: 7.3.3
Imports:
checkmate,
cli,
Expand Down
6 changes: 4 additions & 2 deletions NAMESPACE
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,11 +6,13 @@ export(excluded_locations)
export(generate_hub_baseline)
export(generate_hub_ensemble)
export(generate_oracle_output)
export(get_forecast_data)
export(get_hub_name)
export(get_map_data)
export(included_locations)
export(summarize_ref_date_forecasts)
export(update_authorized_users)
export(update_hub_target_data)
export(write_ref_date_summary)
export(write_ref_date_summary_all)
export(write_ref_date_summary_ensemble)
importFrom(rlang,":=")
importFrom(rlang,.data)
169 changes: 0 additions & 169 deletions R/get_forecast_data.R
View file
Open in desktop
Copy link
Contributor

@dylanhmorris dylanhmorris Dec 5, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is the thought to retain this for backward compatibility? I think it is not used enough yet to make this worthwhile. I would just delete and make sure we port over the (currently one) hub that uses it.

Copy link
Collaborator Author

@O957 O957 Dec 5, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I originally wrote a deprecation comment on both get_*.R files, but I left them with minimal comment, in hopes that you might afford some remarks. I think deleting them makes the most sense (given there is not really a user base who've become accustomed to them) but didn't want to make this decision myself.

This file was deleted.

Loading