Skip to content

Conversation

@O957
Copy link
Collaborator

@O957 O957 commented Nov 21, 2025

This PR:

  • Updates the nssp_update_local option in update_hub_target_data to support parquet files in addition to csv files. Logic is: look for existing latest files where they're expected, handle different states of file presence, and then prefer parquet if it exists.

@O957 O957 self-assigned this Nov 21, 2025
@O957 O957 linked an issue Nov 21, 2025 that may be closed by this pull request
@codecov-commenter
Copy link

codecov-commenter commented Nov 21, 2025

Codecov Report

❌ Patch coverage is 0% with 11 lines in your changes missing coverage. Please review.
✅ Project coverage is 11.85%. Comparing base (d0bfb69) to head (92fa75e).

Files with missing lines Patch % Lines
R/update_hub_target_data.R 0.00% 11 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #64      +/-   ##
==========================================
- Coverage   11.91%   11.85%   -0.07%     
==========================================
  Files           8        8              
  Lines         537      540       +3     
==========================================
  Hits           64       64              
- Misses        473      476       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Contributor

@dylanhmorris dylanhmorris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since this is a functionality that

  • is specific to our two hubs
  • will be removed once we permanently to remote NSSP update

I think it's fine and indeed better just to target .parquet, not fall back on .csv.

@O957 O957 requested a review from dylanhmorris November 24, 2025 14:50
@dylanhmorris dylanhmorris merged commit 3f24f3f into main Nov 24, 2025
6 checks passed
@dylanhmorris dylanhmorris deleted the 63-make-nssp_update_local-option-in-update_hub_target_data-work-with-parquet branch November 24, 2025 17:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Make nssp_update_local option in update_hub_target_data work with parquet

4 participants