ascon: clarfiy vectors are for v1.2 (not SP 800-232)#263
Merged
Conversation
Member
Author
|
@C2SP/wycheproof-reviewers I think this is a pretty easy review if someone has time. |
botovq
approved these changes
Jul 7, 2026
botovq
left a comment
Contributor
There was a problem hiding this comment.
Seems fine. One small suggestion if that makes sense to you.
Add mention to the vector headers that they implement Ascon-128, Ascon-128a, and Ascon-80pq v1.2, the final round submission to the NIST LWC competition. They are **not** interoperable with the SP 800-232 standardized algorithm. We should replace/augment these with SP 800-232 compatible vectors as follow-up. In the meantime, try to avoid potential confusion.
botovq
approved these changes
Jul 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add mention to the
ascon128_test.json,ascon128a_test.json, andascon80pq_test.jsonvector headers that they implement Ascon-128, Ascon-128a, and Ascon-80pq v1.2, the final-round submission to the NIST LWC competition. They are not interoperable with the SP 800-232 standardized algorithm.For reference, see ascon.py and gen_ascon.py from google-wycheproof/v0.9.
We should replace/augment these with SP 800-232 compatible vectors as follow-up. In the meantime, try to avoid potential confusion.
Updates #262