Skip to content

Remove references to Simfony#133

Merged
apoelstra merged 3 commits intoBlockstreamResearch:masterfrom
imaginator:master
Jul 28, 2025
Merged

Remove references to Simfony#133
apoelstra merged 3 commits intoBlockstreamResearch:masterfrom
imaginator:master

Conversation

@imaginator
Copy link
Copy Markdown
Collaborator

AFAIK the only remaining reference is to https://github.com/uncomputable/simfony-as-rust (generates: https://docs.rs/simfony-as-rust/) in the file SimplicityHL/book/src/function.md. I would presume that this should be updated too.

@apoelstra
Copy link
Copy Markdown
Contributor

Welcome @imaginator!

In your second commit it looks like you autoformatted everything with the stable formatter. Unfortunately this is missing a bunch of options that we use. Can you run cargo +nightly fmt to reformat it with the nightly rules?

@imaginator
Copy link
Copy Markdown
Collaborator Author

good to know about cargo +nightly fmt. I spent ages trying to recreate the formatting with a rustfmt.toml file until I gave up and redid everything manually - but three files slipped though.

Copy link
Copy Markdown
Contributor

@apoelstra apoelstra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 4493b60; successfully ran local tests; thanks!

@apoelstra
Copy link
Copy Markdown
Contributor

Looks like there are some clippy failures. I'll deal with this in a followup. I'd like to import all the clippy lints from rust-simplicity and rust-elements.

@apoelstra apoelstra merged commit f61e711 into BlockstreamResearch:master Jul 28, 2025
6 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants