Fix issue #1574: Add location accuracy filter to prevent GPS drift#1702
Closed
Ahmed-Makled wants to merge 5 commits intoBaseflow:mainfrom
Closed
Fix issue #1574: Add location accuracy filter to prevent GPS drift#1702Ahmed-Makled wants to merge 5 commits intoBaseflow:mainfrom
Ahmed-Makled wants to merge 5 commits intoBaseflow:mainfrom
Conversation
0f3ff93 to
ac62031
Compare
…ttings.dart for improved readability
Contributor
|
Dear @Ahmed-Makled, This looks very nice. However, this functionality should in our opinion not be the responsibility of the geolocator package. Unfortunately it is also not part of the iOS package. You can always filter out the inaccurate locations by listening to the positionStream and filter out unwanted locations. Kind regards, |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR addresses issue #1574 by implementing a location accuracy filter to prevent random GPS drift which can cause erratic movement patterns in tracking applications.
Changes
LocationAccuracyFilterclass to filter out location updates with physically implausible movement patternsenableAccuracyFilterparameter toAndroidSettingsclassImplementation Details
The filter works by:
Testing
The implementation includes comprehensive tests for:
This solution is designed to be minimally invasive, with filtering disabled by default to maintain backward compatibility.