Skip to content

Update BabylonNative #664

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 41 commits into
base: master
Choose a base branch
from
Draft
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
41 commits
Select commit Hold shift + click to select a range
ea78d74
Test build
CedricGuillemet May 14, 2025
d027014
no rnta
CedricGuillemet May 14, 2025
9aac684
typo
CedricGuillemet May 14, 2025
9f06763
BN update
CedricGuillemet May 14, 2025
24e9b3d
update libraries after bgfx update
CedricGuillemet May 15, 2025
4a90ea9
graphics warnings
CedricGuillemet May 15, 2025
8c142f1
disable warnings for Windows build
CedricGuillemet May 15, 2025
cc17777
xcode scheme
CedricGuillemet May 16, 2025
d7d00b9
no nativexr for Windows, add schemes for iOS in validation step
CedricGuillemet May 16, 2025
c2e7660
no xr for msvc
CedricGuillemet May 16, 2025
b3af731
removed Windows XR support
CedricGuillemet May 16, 2025
a049ac8
NDK min is 23.1.7779620
CedricGuillemet May 16, 2025
dc72a59
disable warnings xr android
CedricGuillemet May 16, 2025
6b4527a
no warning nativeCamera Android
CedricGuillemet May 16, 2025
492d475
disable XMLHttpRequest warnings
CedricGuillemet May 16, 2025
43ad6c0
even less warnings
CedricGuillemet May 16, 2025
4b0b399
brings back rnta
CedricGuillemet May 17, 2025
28b72f8
windows rnta
CedricGuillemet May 17, 2025
7cd091a
action cache version
CedricGuillemet May 17, 2025
c02b9ed
windows build link path
CedricGuillemet May 17, 2025
78082f6
bimg and bx path
CedricGuillemet May 17, 2025
fa9b729
removed nativexr from linking
CedricGuillemet May 17, 2025
f96c6dc
xr leftovers
CedricGuillemet May 18, 2025
b35ebe7
lib webp windows
CedricGuillemet May 18, 2025
980b5f6
disable webp windows
CedricGuillemet May 18, 2025
2a2fbe6
Scheduling
CedricGuillemet May 18, 2025
f4a09ec
scheduling path
CedricGuillemet May 18, 2025
2f76dd1
actions/download-artifact version
CedricGuillemet May 19, 2025
ed1cd5d
test Xcode 16.2
CedricGuillemet May 21, 2025
b3d9298
Test Node 18
CedricGuillemet May 21, 2025
a01a58c
up cmake version
CedricGuillemet May 21, 2025
271b27d
bump to 0.71
CedricGuillemet May 21, 2025
9ec4d73
no webp
CedricGuillemet May 22, 2025
e2bcae5
removed webp
CedricGuillemet May 22, 2025
22cabfa
moved back to a version that should build
CedricGuillemet Jun 17, 2025
2832d92
windows 2019 is deprecated
CedricGuillemet Jun 17, 2025
ee35f80
vs 2022
CedricGuillemet Jun 17, 2025
c668234
windows sdk version
CedricGuillemet Jun 18, 2025
a719001
missing scheduling lib
CedricGuillemet Jun 18, 2025
59cb04b
WindowsTargetPlatformVersion test
CedricGuillemet Jun 18, 2025
f75fd02
disable windows
CedricGuillemet Jun 18, 2025
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
86 changes: 43 additions & 43 deletions .github/workflows/bn_master_commit.yml
Original file line number Diff line number Diff line change
Expand Up @@ -76,46 +76,46 @@ jobs:
run: npx gulp buildIOS
working-directory: ./Package

build-windows:
name: Build Windows ${{ matrix.platform }} ${{ matrix.config }} - BabylonNative ${{ github.event.client_payload.sha }}
runs-on: windows-2019
strategy:
matrix:
platform: [x86, x64, ARM64]
config: [Debug, Release]
steps:
- name: Checkout Repo
uses: actions/[email protected]
with:
submodules: 'true'
- name: Setup MSBuild
uses: microsoft/[email protected]
- name: Setup Node 16
uses: actions/setup-node@v3
with:
node-version: 16
- name: Setup NuGet
uses: nuget/setup-nuget@v1
with:
nuget-version: '5.x'
- name: NPM Install (Playground)
run: npm install
working-directory: ./Apps/Playground
- name: NPM Install (React Native ${{ env.BRN_Version }})
run: npm run select --reactNative ${{ env.BRN_Version }}
working-directory: ./Apps/Playground
- name: NPM Install (Binary Package)
run: npm install
working-directory: ./Package
- name: Gulp Setup Project ${{ matrix.platform }} (Windows)
run: npx gulp makeUWPProject${{ matrix.platform }}
working-directory: ./Package
- name: Gulp Build ${{ matrix.platform }} ${{ matrix.config }} (Windows)
run: npx gulp buildUWP${{ matrix.platform }}${{ matrix.config }}
working-directory: ./Package
- name: Gulp NuGet Restore Playground
run: npx gulp nugetRestoreUWPPlayground
working-directory: ./Package
- name: Gulp Build ${{ matrix.platform }} ${{ matrix.config }} Playground (Windows)
run: npx gulp buildUWPPlayground${{ matrix.platform }}${{ matrix.config }}
working-directory: ./Package
# build-windows:
# name: Build Windows ${{ matrix.platform }} ${{ matrix.config }} - BabylonNative ${{ github.event.client_payload.sha }}
# runs-on: windows-latest
# strategy:
# matrix:
# platform: [x86, x64, ARM64]
# config: [Debug, Release]
# steps:
# - name: Checkout Repo
# uses: actions/[email protected]
# with:
# submodules: 'true'
# - name: Setup MSBuild
# uses: microsoft/[email protected]
# - name: Setup Node 16
# uses: actions/setup-node@v3
# with:
# node-version: 16
# - name: Setup NuGet
# uses: nuget/setup-nuget@v1
# with:
# nuget-version: '5.x'
# - name: NPM Install (Playground)
# run: npm install
# working-directory: ./Apps/Playground
# - name: NPM Install (React Native ${{ env.BRN_Version }})
# run: npm run select --reactNative ${{ env.BRN_Version }}
# working-directory: ./Apps/Playground
# - name: NPM Install (Binary Package)
# run: npm install
# working-directory: ./Package
# - name: Gulp Setup Project ${{ matrix.platform }} (Windows)
# run: npx gulp makeUWPProject${{ matrix.platform }}
# working-directory: ./Package
# - name: Gulp Build ${{ matrix.platform }} ${{ matrix.config }} (Windows)
# run: npx gulp buildUWP${{ matrix.platform }}${{ matrix.config }}
# working-directory: ./Package
# - name: Gulp NuGet Restore Playground
# run: npx gulp nugetRestoreUWPPlayground
# working-directory: ./Package
# - name: Gulp Build ${{ matrix.platform }} ${{ matrix.config }} Playground (Windows)
# run: npx gulp buildUWPPlayground${{ matrix.platform }}${{ matrix.config }}
# working-directory: ./Package
221 changes: 111 additions & 110 deletions .github/workflows/pr.yml
Original file line number Diff line number Diff line change
Expand Up @@ -141,7 +141,7 @@ jobs:
working-directory: ./Package

- name: Cache XCFrameworks
uses: actions/cache@v2
uses: actions/cache@v4
with:
path: Modules/@babylonjs/react-native-iosandroid/ios/libs
key: ${{ runner.os }}-xcframeworks-${{ github.sha }}
Expand Down Expand Up @@ -188,106 +188,107 @@ jobs:
env:
JAVA_HOME: ${{ env.JAVA_HOME_11_X64 }}

build-windows:
runs-on: windows-2019
strategy:
matrix:
platform: [x86, x64, ARM64]
config: [Debug, Release]
steps:
- name: Support longpaths
run: git config --system core.longpaths true
- name: Checkout Repo
uses: actions/[email protected]
with:
submodules: 'true'
- name: Setup MSBuild
uses: microsoft/[email protected]
- name: Setup Node 16
uses: actions/setup-node@v3
with:
node-version: 16
- name: Setup NuGet
uses: nuget/setup-nuget@v1
with:
nuget-version: '5.x'
- name: NPM Install (Playground)
run: npm install
working-directory: ./Apps/Playground
- name: NPM Install (React Native ${{ env.BRN_Version }})
run: npm run select ${{ env.BRN_Version }}
working-directory: ./Apps/Playground
- name: NPM Install (Binary Package)
run: npm install
working-directory: ./Package
- name: Gulp Setup Project ${{ matrix.platform }} (Windows)
run: npx gulp makeUWPProject${{ matrix.platform }}
working-directory: ./Package
- name: Gulp Build ${{ matrix.platform }} ${{ matrix.config }} (Windows)
run: npx gulp buildUWP${{ matrix.platform }}${{ matrix.config }}
working-directory: ./Package
- name: Gulp NuGet Restore Playground
run: npx gulp nugetRestoreUWPPlayground
working-directory: ./Package
- name: Gulp Build ${{ matrix.platform }} ${{ matrix.config }} Playground (Windows)
run: npx gulp buildUWPPlayground${{ matrix.platform }}${{ matrix.config }}
working-directory: ./Package
# build-windows:
# runs-on: windows-latest
# strategy:
# matrix:
# platform: [x86, x64, ARM64]
# config: [Debug, Release]
# steps:
# - name: Support longpaths
# run: git config --system core.longpaths true
# - name: Checkout Repo
# uses: actions/[email protected]
# with:
# submodules: 'true'
# - name: Setup MSBuild
# uses: microsoft/[email protected]
# - name: Setup Node 16
# uses: actions/setup-node@v3
# with:
# node-version: 16
# - name: Setup NuGet
# uses: nuget/setup-nuget@v1
# with:
# nuget-version: '5.x'
# - name: NPM Install (Playground)
# run: npm install
# working-directory: ./Apps/Playground
# - name: NPM Install (React Native ${{ env.BRN_Version }})
# run: npm run select ${{ env.BRN_Version }}
# working-directory: ./Apps/Playground
# - name: NPM Install (Binary Package)
# run: npm install
# working-directory: ./Package
# - name: Gulp Setup Project ${{ matrix.platform }} (Windows)
# run: npx gulp makeUWPProject${{ matrix.platform }}
# working-directory: ./Package
# - name: Gulp Build ${{ matrix.platform }} ${{ matrix.config }} (Windows)
# run: |
# npx gulp buildUWP${{ matrix.platform }}${{ matrix.config }}
# working-directory: ./Package
# - name: Gulp NuGet Restore Playground
# run: npx gulp nugetRestoreUWPPlayground
# working-directory: ./Package
# - name: Gulp Build ${{ matrix.platform }} ${{ matrix.config }} Playground (Windows)
# run: npx gulp buildUWPPlayground${{ matrix.platform }}${{ matrix.config }}
# working-directory: ./Package

build-windows-rnta:
runs-on: windows-2019
steps:
- name: Support longpaths
run: git config --system core.longpaths true
- name: Checkout Repo
uses: actions/[email protected]
with:
submodules: 'true'
- name: Setup MSBuild
uses: microsoft/[email protected]
- name: Setup Node 20
uses: actions/setup-node@v3
with:
node-version: 20
# build-windows-rnta:
# runs-on: windows-latest
# steps:
# - name: Support longpaths
# run: git config --system core.longpaths true
# - name: Checkout Repo
# uses: actions/[email protected]
# with:
# submodules: 'true'
# - name: Setup MSBuild
# uses: microsoft/[email protected]
# - name: Setup Node 20
# uses: actions/setup-node@v3
# with:
# node-version: 20

- name: Install watchman
run: choco install watchman
working-directory: ./Apps/BRNPlayground
# - name: Install watchman
# run: choco install watchman
# working-directory: ./Apps/BRNPlayground

- name: NPM Install RNTA
run: npm install
working-directory: ./Apps/BRNPlayground
# - name: NPM Install RNTA
# run: npm install
# working-directory: ./Apps/BRNPlayground

- name: Build Windows Bundle
run: npm run build:windows
working-directory: ./Apps/BRNPlayground
# - name: Build Windows Bundle
# run: npm run build:windows
# working-directory: ./Apps/BRNPlayground

- name: NPM Install Package
run: npm install
working-directory: ./Package
# - name: NPM Install Package
# run: npm install
# working-directory: ./Package

- name: NPM Generate Windows Project
run: npx install-windows-test-app
working-directory: ./Apps/BRNPlayground
# - name: NPM Generate Windows Project
# run: npx install-windows-test-app
# working-directory: ./Apps/BRNPlayground

- name: BabylonNative build directory
run: mkdir @babylonjs/react-native/Build/uwp_x64
working-directory: ./Modules
# - name: BabylonNative build directory
# run: mkdir @babylonjs/react-native/Build/uwp_x64
# working-directory: ./Modules

- name: CMake BabylonNative
run: cmake -G "Visual Studio 16 2019" -D CMAKE_SYSTEM_NAME=WindowsStore -D CMAKE_SYSTEM_VERSION=10.0.19041.0 -DCMAKE_UNITY_BUILD=true -D CMAKE_VS_WINDOWS_TARGET_PLATFORM_VERSION_MAXIMUM=10.0.19041.0 -A x64 ./../../../react-native-windows/windows
working-directory: ./Modules/@babylonjs/react-native/Build/uwp_x64
# - name: CMake BabylonNative
# run: cmake -G "Visual Studio 17 2022" -D CMAKE_SYSTEM_NAME=WindowsStore -D CMAKE_SYSTEM_VERSION=10.0.19041.0 -DCMAKE_UNITY_BUILD=true -D CMAKE_VS_WINDOWS_TARGET_PLATFORM_VERSION_MAXIMUM=10.0.19041.0 -A x64 ./../../../react-native-windows/windows
# working-directory: ./Modules/@babylonjs/react-native/Build/uwp_x64

- name: Nuget restore
run: nuget restore BRNPlayground.sln
working-directory: ./Apps/BRNPlayground/windows
# - name: Nuget restore
# run: nuget restore BRNPlayground.sln
# working-directory: ./Apps/BRNPlayground/windows

- name: Windows build BN
run: MSBuild /p:Platform="x64" /p:Configuration="Release" /m ReactNativeBabylon.sln
working-directory: ./Modules/@babylonjs/react-native/Build/uwp_x64
# - name: Windows build BN
# run: MSBuild /p:Platform="x64" /p:Configuration="Release" /p:WindowsTargetPlatformVersion=10.0.19041.0 /m ReactNativeBabylon.sln
# working-directory: ./Modules/@babylonjs/react-native/Build/uwp_x64

- name: Windows build BRN
run: MSBuild /p:Platform="x64" /p:Configuration="Release" /m BRNPlayground.sln
working-directory: ./Apps/BRNPlayground/windows
# - name: Windows build BRN
# run: MSBuild /p:Platform="x64" /p:Configuration="Release" /p:WindowsTargetPlatformVersion=10.0.19041.0 /m BRNPlayground.sln
# working-directory: ./Apps/BRNPlayground/windows

# Test packages
build-android-ios-065:
Expand All @@ -314,29 +315,29 @@ jobs:
react-native-version: '0.71'
release-version: 0.0.${GITHUB_SHA::8}

build-windows-065:
uses: ./.github/workflows/windows.yml
with:
react-native-version: '0.65'
release-version: 0.0.${GITHUB_SHA::8}
# build-windows-065:
# uses: ./.github/workflows/windows.yml
# with:
# react-native-version: '0.65'
# release-version: 0.0.${GITHUB_SHA::8}

build-windows-069:
uses: ./.github/workflows/windows.yml
with:
react-native-version: '0.69'
release-version: 0.0.${GITHUB_SHA::8}
# build-windows-069:
# uses: ./.github/workflows/windows.yml
# with:
# react-native-version: '0.69'
# release-version: 0.0.${GITHUB_SHA::8}

build-windows-070:
uses: ./.github/workflows/windows.yml
with:
react-native-version: '0.70'
release-version: 0.0.${GITHUB_SHA::8}
# build-windows-070:
# uses: ./.github/workflows/windows.yml
# with:
# react-native-version: '0.70'
# release-version: 0.0.${GITHUB_SHA::8}

build-windows-071:
uses: ./.github/workflows/windows.yml
with:
react-native-version: '0.71'
release-version: 0.0.${GITHUB_SHA::8}
# build-windows-071:
# uses: ./.github/workflows/windows.yml
# with:
# react-native-version: '0.71'
# release-version: 0.0.${GITHUB_SHA::8}

build-typescript:
uses: ./.github/workflows/typescript.yml
Expand Down
Loading
Loading