Conversation
|
Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s). |
There was a problem hiding this comment.
Pull request overview
Fixes undo/redo behavior in the Node Render Graph Editor (NRGE) by preserving host-provided external input values across graph re-parses, and addresses related preview/GUI lifecycle issues that caused the GUI layer to disappear after undo.
Changes:
- Preserve and restore external
NodeRenderGraphInputBlockvalues during history undo/redo application (values aren’t part of the serialized graph). - Ensure the preview scene detaches its
frameGraphon dispose to restore the scene render path cleanly. - Create standalone fullscreen GUI ADTs with an explicit
sceneso the GUI layer is associated with the correct scene.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| packages/tools/nodeRenderGraphEditor/src/graphEditor.tsx | Saves/restores external input values around parseSerializedObject during undo/redo. |
| packages/tools/nodeRenderGraphEditor/src/components/preview/previewManager.ts | Clears scene.frameGraph before disposing to avoid leaving the scene in frame-graph render mode. |
| packages/dev/gui/src/2D/FrameGraph/renderGraphGUIBlock.ts | Passes scene into ADT fullscreen creation options for correct scene association. |
| packages/dev/gui/src/2D/FrameGraph/guiTask.ts | When creating an internal ADT, passes scene: frameGraph.scene in options. |
|
Snapshot stored with reference name: Test environment: To test a playground add it to the URL, for example: https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/refs/pull/17999/merge/index.html#WGZLGJ#4600 Links to test your changes to core in the published versions of the Babylon tools (does not contain changes you made to the tools themselves): https://playground.babylonjs.com/?snapshot=refs/pull/17999/merge To test the snapshot in the playground with a playground ID add it after the snapshot query string: https://playground.babylonjs.com/?snapshot=refs/pull/17999/merge#BCU1XR#0 If you made changes to the sandbox or playground in this PR, additional comments will be generated soon containing links to the dev versions of those tools. |
|
WebGL2 visualization test reporter: |
|
Visualization tests for WebGPU |
See https://forum.babylonjs.com/t/ctrl-z-in-frame-graph-brokes-playground-demo/62620
It also fixes the GUI button disappearing in the example PG when we undo a change (though, for this to work, the GUI button must be created in
nrg.onBeforeBuildObservableor innrg.onBuildObservable, see http://playground.babylonjs.com/#JWKDME#213).