TEST: More of Fluent added in #16747
Conversation
…rtyLineProps helper
…dd controlled state to syncedSlider; remove index from dropdown key; ToolHostProps use PropsWithChildren; restore package.json;
… wrapper, enable in NME, test if build fails
…n/Babylon.js into sharedComponents1
|
Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s). |
|
Reviewer - this PR has made changes to one or more package.json files. |
|
Building or testing the sandbox has failed. If the tests failed, results can be found here: |
|
Snapshot stored with reference name: Test environment: To test a playground add it to the URL, for example: https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/refs/pull/16747/merge/index.html#WGZLGJ#4600 Links to test babylon tools with this snapshot: https://playground.babylonjs.com/?snapshot=refs/pull/16747/merge To test the snapshot in the playground with a playground ID add it after the snapshot query string: https://playground.babylonjs.com/?snapshot=refs/pull/16747/merge#BCU1XR#0 |
|
You have made possible changes to the playground. https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/PLAYGROUND/refs/pull/16747/merge/ The snapshot playground with the CDN snapshot (only when available): Note that neither Babylon scenes nor textures are uploaded to the snapshot directory, so some playgrounds won't work correctly. |
|
WebGL2 visualization test reporter: |
|
Visualization tests for WebGPU |
|
You have changed file(s) that made possible changes to the sandbox. https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/SANDBOX/refs/pull/16747/merge/ |
|
Reviewer - this PR has made changes to one or more package.json files. |
|
You have made possible changes to the playground. https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/PLAYGROUND/refs/pull/16747/merge/ The snapshot playground with the CDN snapshot (only when available): Note that neither Babylon scenes nor textures are uploaded to the snapshot directory, so some playgrounds won't work correctly. |
|
You have changed file(s) that made possible changes to the sandbox. https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/SANDBOX/refs/pull/16747/merge/ |
|
WebGL2 visualization test reporter: |
|
Visualization tests for WebGPU |
….json to point to minified bundle (#16759) When introducing fluent dependency in [this PR](#16709) we saw our build agents running out of memory when running es6/UMD build steps, and we also saw the importing of public inspector package causing heap allocation error in the test app sceneWithInspector test. After many attempts to solve (branching off onto another [smaller PR](#16747) to isolate the causes) the solution we are landing on is to reduce parallelization of build steps (solving OOM during es6/UMD build, and confirmed that it wont slow down our build) and to update the inspector and gui editor package.json to point to the minified bundle (solving heap allocation error, and confirmed via npm link + babylonjs-webpack-es6 test app that inspector loads properly) Co-authored-by: Georgina <[email protected]>
|
Can we close that one @ryantrem ? |
5 participants
Merging #16730 into #16709 and testing the build.