Viewer: Switch from ShadowOnlyMaterial to BackgroundMaterial #16707
Conversation
|
Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s). |
|
Reviewer - this PR has made changes to one or more package.json files. |
|
Snapshot stored with reference name: Test environment: To test a playground add it to the URL, for example: https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/refs/pull/16707/merge/index.html#WGZLGJ#4600 Links to test babylon tools with this snapshot: https://playground.babylonjs.com/?snapshot=refs/pull/16707/merge To test the snapshot in the playground with a playground ID add it after the snapshot query string: https://playground.babylonjs.com/?snapshot=refs/pull/16707/merge#BCU1XR#0 |
|
Visualization tests for WebGPU |
|
WebGL2 visualization test reporter: |
3 participants
ShadowOnlyMaterialdoes not currently have a native wgsl implementation, which means it has to be converted to glsl at runtime, which is not ideal. Switching toBackgroundMaterialsolves this, plus it removes the dependency on@babylonjs/materials.I also switched the skybox material over to
BackgroundMaterialsince it can do what we need in a lighter weight way (unlit + reflection blur). In doing so, it revealed a bug inBackgroundMaterial's wgls fragment shader implementation, where it was simply missinguniforms.when referencing thevReflectionMicrosurfaceInfosuniform.This PR also includes a few other small Viewer changes related to shadows:
ShadowLightinstead ofSpotlight. This is really just in preparation to switch toDirectionalLight, which will be a different PR.ShadowGenerator.enableSoftTransparentShadow = true;(feedback from @Popov72).ShadowGenerator.bias = radius / 1000;(feedback from @Popov72, and we'll see if we need to also allow the user to explicitly override thebias).