-
Notifications
You must be signed in to change notification settings - Fork 3.5k
Viewer IBL shadow fixes #16696
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Viewer IBL shadow fixes #16696
Conversation
Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s). |
Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s). |
Snapshot stored with reference name: Test environment: To test a playground add it to the URL, for example: https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/refs/pull/16696/merge/index.html#WGZLGJ#4600 Links to test babylon tools with this snapshot: https://playground.babylonjs.com/?snapshot=refs/pull/16696/merge To test the snapshot in the playground with a playground ID add it after the snapshot query string: https://playground.babylonjs.com/?snapshot=refs/pull/16696/merge#BCU1XR#0 |
WebGL2 visualization test reporter: |
Visualization tests for WebGPU |
Hide shadows when no models are loaded
Visualization tests for WebGPU |
WebGL2 visualization test reporter: |
LGTM but let s have @ryantrem checking it |
Yep I've reviewed and tested locally. I pushed a couple changes to this PR, but I'd like @alexandremottet to look just to be sure, and then we can merge. |
No description provided.