Skip to content

Viewer IBL shadow fixes #16696

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jun 3, 2025

Conversation

MiiBond
Copy link
Contributor

@MiiBond MiiBond commented May 30, 2025

No description provided.

@bjsplat
Copy link
Collaborator

bjsplat commented May 30, 2025

Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s).
To prevent this PR from going to the changelog marked it with the "skip changelog" label.

@bjsplat
Copy link
Collaborator

bjsplat commented May 30, 2025

Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s).
To prevent this PR from going to the changelog marked it with the "skip changelog" label.

@bjsplat
Copy link
Collaborator

bjsplat commented May 30, 2025

@bjsplat
Copy link
Collaborator

bjsplat commented May 30, 2025

@bjsplat
Copy link
Collaborator

bjsplat commented May 30, 2025

@bjsplat
Copy link
Collaborator

bjsplat commented Jun 2, 2025

@bjsplat
Copy link
Collaborator

bjsplat commented Jun 2, 2025

@sebavan sebavan requested a review from ryantrem June 2, 2025 20:01
@sebavan
Copy link
Member

sebavan commented Jun 2, 2025

LGTM but let s have @ryantrem checking it

@ryantrem
Copy link
Member

ryantrem commented Jun 2, 2025

Yep I've reviewed and tested locally. I pushed a couple changes to this PR, but I'd like @alexandremottet to look just to be sure, and then we can merge.

@ryantrem ryantrem merged commit b181367 into BabylonJS:master Jun 3, 2025
18 checks passed
@ryantrem ryantrem mentioned this pull request Jun 10, 2025
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants