Laravel Dusk implementation via Selenium container #7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ault by commenting it out; added information into readme;
dejwCake
reviewed
Apr 9, 2020
| # selenium: | ||
| # image: selenium/standalone-chrome:3.11.0-antimony | ||
| # volumes: | ||
| # - /dev/shm:/dev/shm |
There was a problem hiding this comment.
why do you need this volume?
There was a problem hiding this comment.
I think that I found this as recommendation for selenium implementation. Look for example here:
https://sondnm.github.io/blog/2018/09/08/i-just-learnt-about-/dev/shm/ - selenium will be able to use host shared memory ( in cases container consumes too much memory, it can use host shared memory )
…enough - altered readme;
…ame as in .env ) so therefore removed it from instructions for altering env variables;
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
added section into yml for selenium service - it is turned off by default by commenting it out;
added information into readme;