Conversation
Co-authored-by: matthchr <8798850+matthchr@users.noreply.github.com>
| │ │ ├── ConfigMapExpressions: *core.DestinationExpression[] | ||
| │ │ └── SecretExpressions: *core.DestinationExpression[] | ||
| │ ├── Owner: *genruntime.KnownResourceReference | ||
| │ └── SystemData: *Object (6 properties) |
There was a problem hiding this comment.
This field should be readonly. @copilot please prune this SystemData field to the v2/azure-arm.yaml file (see other examples in the file for reference).
There was a problem hiding this comment.
Done. Removed SystemData from AccessConnector_Spec in 1889f01.
Co-authored-by: matthchr <8798850+matthchr@users.noreply.github.com>
| │ ├── AzureName: Validated<string> (2 rules) | ||
| │ │ ├── Rule 0: MaxLength: 64 | ||
| │ │ └── Rule 1: MinLength: 3 | ||
| │ ├── CreatedDateTime: *string |
| │ │ └── SecretExpressions: *core.DestinationExpression[] | ||
| │ ├── Owner: *genruntime.KnownResourceReference | ||
| │ ├── Parameters: *Object (15 properties) | ||
| │ │ ├── AmlWorkspaceId: *Object (2 properties) |
There was a problem hiding this comment.
We need to do something here but I am not sure what.
There was a problem hiding this comment.
I think ideally we would be able to swap each of these objects (or at least the ones with ARM ID refs) to refer to a special variant of WorkspaceCustomStringParameter (which is the parameter they use for both IDs and names here).
We want (for the ID parameters) to use an ASOWorkspaceCustomStringParameter which has the arm-id flag on the value, but leave the things like subnet names as just strings
… resources Co-authored-by: matthchr <8798850+matthchr@users.noreply.github.com>
What this PR does
Adds support for Microsoft.Databricks resources using the stable 2024-05-01 API version.
Closes #4345
Resources Added
AccessConnector- Secure data access for Databricks workspacesWorkspace- Main Databricks workspace resourceWorkspacesPrivateEndpointConnection- Private endpoint managementWorkspacesVirtualNetworkPeering- VNet peering configurationImplementation
Added databricks service configuration to
azure-arm.yaml:Configured ARM reference types for VirtualNetworkPeering properties to enable cross-resource references. Removed readonly properties (
SystemDatafromAccessConnector_SpecandCreatedDateTimefromWorkspaceProperties) that should only appear in status. Code generator produced 53 files including CRDs, Go types, ARM conversions, storage types, webhooks, and tests.Usage
How does this PR make you feel?
Checklist
Original prompt
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.