Skip to content

[Search] Fix tests and pipeline failures #50255

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 27, 2025

Conversation

ShivangiReja
Copy link
Member

@Copilot Copilot AI review requested due to automatic review settings May 23, 2025 21:36
@ShivangiReja ShivangiReja requested review from kinelski and a team as code owners May 23, 2025 21:36
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR removes obsolete LiveOnly test attributes, updates skill mappings for new ChatCompletionSkill, and bumps the assets tag to resolve build pipeline failures.

  • Removed [LiveOnly] annotations from test methods now compatible with playback.
  • Added ChatCompletionSkill support in skill factory methods.
  • Updated autorest.md, model initialization, and bumped assets.json tag to fix generation and pipeline errors.

Reviewed Changes

Copilot reviewed 7 out of 7 changed files in this pull request and generated 3 comments.

Show a summary per file
File Description
tests/SearchIndexerClientTests.cs Removed stale LiveOnly attributes and added ChatCompletionSkill mappings in factory methods.
tests/Samples/Sample01_HelloWorld.cs Removed stale LiveOnly annotation from sample tests.
src/autorest.md Added a YAML transform to remove nullable annotations from Swagger.
src/Indexes/Models/SearchIndexerDataSourceConnection.cs Initialized IndexerPermissionOptions and added missing System.Collections.Generic import.
assets.json Updated the Tag value to match the new build output.

@ShivangiReja
Copy link
Member Author

/azp run net - search - tests

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

Copy link

github-actions bot commented May 23, 2025

API Change Check

APIView identified API level changes in this PR and created the following API reviews

Azure.Search.Documents

@ShivangiReja ShivangiReja merged commit 44471ca into Azure:main May 27, 2025
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Search] Reenable and rerecord tests that require storage account access
2 participants