[Search] Fix tests and pipeline failures #50255
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR removes obsolete LiveOnly test attributes, updates skill mappings for new ChatCompletionSkill, and bumps the assets tag to resolve build pipeline failures.
- Removed
[LiveOnly]annotations from test methods now compatible with playback. - Added
ChatCompletionSkillsupport in skill factory methods. - Updated
autorest.md, model initialization, and bumpedassets.jsontag to fix generation and pipeline errors.
Reviewed Changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| tests/SearchIndexerClientTests.cs | Removed stale LiveOnly attributes and added ChatCompletionSkill mappings in factory methods. |
| tests/Samples/Sample01_HelloWorld.cs | Removed stale LiveOnly annotation from sample tests. |
| src/autorest.md | Added a YAML transform to remove nullable annotations from Swagger. |
| src/Indexes/Models/SearchIndexerDataSourceConnection.cs | Initialized IndexerPermissionOptions and added missing System.Collections.Generic import. |
| assets.json | Updated the Tag value to match the new build output. |
sdk/search/Azure.Search.Documents/src/Indexes/Models/SearchIndexerDataSourceConnection.cs
Show resolved
Hide resolved
|
/azp run net - search - tests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
API Change CheckAPIView identified API level changes in this PR and created the following API reviews |
alzimmermsft
approved these changes
May 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #48588
This PR also fixes the pipeline failures - https://dev.azure.com/azure-sdk/internal/_build?definitionId=1594&_a=summary