Expose ModelReaderWriterContextSnippets #50234
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
live1206
requested review from
JoshLove-msft,
m-nash,
jorgerangel-msft,
ArcturusZhang,
jsquire,
christothes,
annelo-msft,
KrzysztofCwalina,
tg-msft and
ArthurMa1978
as code owners
github-actions
bot
added
Client
There was a problem hiding this comment.
Pull Request Overview
This PR updates version numbers to expose ModelReaderWriterContextSnippets based on upstream changes. It bumps the "@typespec/http-client-csharp" dependency and updates the UnbrandedGeneratorVersion accordingly.
- Update of "@typespec/http-client-csharp" version in package.json.
- Bump of UnbrandedGeneratorVersion in Packages.Data.props.
Reviewed Changes
Copilot reviewed 2 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| eng/packages/http-client-csharp/package.json | Updated dependency version to expose new context snippets. |
| eng/Packages.Data.props | Updated UnbrandedGeneratorVersion for generator changes. |
Files not reviewed (1)
- eng/packages/http-client-csharp/package-lock.json: Language not supported
Comments suppressed due to low confidence (1)
eng/Packages.Data.props:441
- [nitpick] Consider reviewing whether the AzureGeneratorVersion should also be updated for consistency, or document the reason for leaving it unchanged.
<UnbrandedGeneratorVersion>1.0.0-alpha.20250522.3</UnbrandedGeneratorVersion>
ArcturusZhang
approved these changes
May 23, 2025
ArthurMa1978
approved these changes
May 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Apply changes of microsoft/typespec#7452
Contributes to #50229