[AutoPR @azure-arm-monitorslis]-generated-from-SDK Generation - JS-6195149#38255
Draft
[AutoPR @azure-arm-monitorslis]-generated-from-SDK Generation - JS-6195149#38255
Conversation
…rosoft.Monitor/Slis/tspconfig.yaml', and CommitSHA: 'd32a3f6cc49c6dd6604161f8c7cee7c95a84c578' in SpecRepo: 'https://github.com/Azure/azure-rest-api-specs' Pipeline run: https://dev.azure.com/azure-sdk/internal/_build/results?buildId=6195149 Refer to https://eng.ms/docs/products/azure-developer-experience/develop/sdk-release/sdk-release-prerequisites to prepare for SDK release.
github-actions
Bot
added
the
Mgmt
kazrael2119
added
Self-Service Release
kazrael2119
requested review from
a team,
JialinHuang803,
MaryGao,
jeremymeng,
qiaozha and
xirzec
as code owners
Contributor
Next Steps to MergeOnly failed checks and required actions are listed below.
|
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
No API design issues found. The public API surface in review/arm-monitorslis-node.api.md is clean: package version 1.0.0-beta.1 is consistently aligned across package.json, src/api/monitorContext.ts (azsdk-js-arm-monitorslis/1.0.0-beta.1), and CHANGELOG.md; the first CHANGELOG entry uses expected hard-coded content; KnownVersions correctly contains only 2025-03-01-preview; no _N, AutoGenerated, or _-prefix naming issues; no type-safety violations; and pnpm-lock.yaml now properly includes prettier@3.8.2 (resolving the blocking lockfile issue from the prior generation in PR #38214).
📊 Structured Report
{"agent":"mgmt-reviewer","pr":38255,"summary":"clean","findings":[]}⚡ Benchmarked by Management Release Assistant
Contributor
There was a problem hiding this comment.
Pull request overview
This PR appears to be an AutoPR that introduces a newly generated Azure Resource Manager (mgmt) client package @azure/arm-monitorslis (Monitor SLIs) from the referenced TypeSpec configuration, and wires it into the repo’s CI/ownership/link-check infrastructure.
Changes:
- Add the new
sdk/monitor/arm-monitorslispackage (generated client, models, helpers, tests, samples, API reports, configs). - Update
sdk/monitor/ci.mgmt.ymlto include the new package in CI. - Update repo metadata/infra files (
pnpm-lock.yaml,eng/ignore-links.txt,.github/CODEOWNERS) to recognize the new package and links.
Reviewed changes
Copilot reviewed 64 out of 65 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| sdk/monitor/ci.mgmt.yml | Adds arm-monitorslis to CI trigger paths and pipeline matrix. |
| sdk/monitor/arm-monitorslis/warp.config.yml | Warp build/export configuration for multi-target outputs. |
| sdk/monitor/arm-monitorslis/vitest.config.ts | Points package vitest config at the shared node config. |
| sdk/monitor/arm-monitorslis/vitest.browser.config.ts | Points package vitest browser config at the shared browser config. |
| sdk/monitor/arm-monitorslis/vitest.esm.config.ts | Adds ESM vitest config (currently imports a missing shared file). |
| sdk/monitor/arm-monitorslis/tsp-location.yaml | Records spec repo location/commit for generation provenance. |
| sdk/monitor/arm-monitorslis/tsconfig.json | Project references for package build/test/snippets/samples. |
| sdk/monitor/arm-monitorslis/tsconfig.src.json | Source TS config extending repo defaults. |
| sdk/monitor/arm-monitorslis/tsconfig.samples.json | Samples TS config and path mapping to built ESM output. |
| sdk/monitor/arm-monitorslis/tsconfig.test.json | Test TS references (node + browser). |
| sdk/monitor/arm-monitorslis/tsconfig.test.node.json | Node-test TS config paths for local source testing. |
| sdk/monitor/arm-monitorslis/tsconfig.browser.config.json | Browser-test TS config paths to browser d.ts output. |
| sdk/monitor/arm-monitorslis/tsconfig.snippets.json | Snippets TS config extending repo snippets base. |
| sdk/monitor/arm-monitorslis/test/snippets.spec.ts | Snippet sources for README/docs extraction (excluded from test runs). |
| sdk/monitor/arm-monitorslis/test/public/utils/recordedClient.ts | Recorder helper for live/playback tests (currently unused in sample test). |
| sdk/monitor/arm-monitorslis/test/public/sampleTest.spec.ts | Placeholder/public test scaffolding. |
| sdk/monitor/arm-monitorslis/src/static-helpers/urlTemplate.ts | RFC6570 URL template expansion helper (issues found in empty-value handling & reserved encoding logic). |
| sdk/monitor/arm-monitorslis/src/static-helpers/pagingHelpers.ts | Generic paging helper for PagedAsyncIterableIterator. |
| sdk/monitor/arm-monitorslis/src/static-helpers/cloudSettingHelpers.ts | Cloud selection helper for ARM endpoint resolution. |
| sdk/monitor/arm-monitorslis/src/logger.ts | Client logger initialization. |
| sdk/monitor/arm-monitorslis/src/models/models.ts | Generated models + (de)serializers. |
| sdk/monitor/arm-monitorslis/src/models/index.ts | Public export surface for models/known enums. |
| sdk/monitor/arm-monitorslis/src/api/monitorContext.ts | REST client context creation (endpoint, UA, scopes, logging). |
| sdk/monitor/arm-monitorslis/src/api/index.ts | Exports MonitorContext and createMonitor. |
| sdk/monitor/arm-monitorslis/src/api/slis/options.ts | OperationOptions-derived option bags for SLIs operations. |
| sdk/monitor/arm-monitorslis/src/api/slis/operations.ts | Generated REST operations for SLIs (list/get/createOrUpdate/delete). |
| sdk/monitor/arm-monitorslis/src/api/slis/index.ts | Barrel export for SLIs operation functions/options. |
| sdk/monitor/arm-monitorslis/src/classic/index.ts | Classic layer entry exports. |
| sdk/monitor/arm-monitorslis/src/classic/slis/index.ts | Classic convenience wrapper for SLIs operation group. |
| sdk/monitor/arm-monitorslis/src/monitorClient.ts | Top-level MonitorClient exposing operation groups. |
| sdk/monitor/arm-monitorslis/src/index.ts | Package public entrypoint exports (client, models, helpers, types). |
| sdk/monitor/arm-monitorslis/samples/v1-beta/typescript/package.json | TS samples package manifest. |
| sdk/monitor/arm-monitorslis/samples/v1-beta/typescript/tsconfig.json | TS samples compiler config. |
| sdk/monitor/arm-monitorslis/samples/v1-beta/typescript/README.md | TS samples README. |
| sdk/monitor/arm-monitorslis/samples/v1-beta/typescript/sample.env | TS samples env template. |
| sdk/monitor/arm-monitorslis/samples/v1-beta/typescript/src/slisCreateOrUpdateSample.ts | TS sample for createOrUpdate. |
| sdk/monitor/arm-monitorslis/samples/v1-beta/typescript/src/slisDeleteSample.ts | TS sample for delete. |
| sdk/monitor/arm-monitorslis/samples/v1-beta/typescript/src/slisGetSample.ts | TS sample for get. |
| sdk/monitor/arm-monitorslis/samples/v1-beta/typescript/src/slisListByParentSample.ts | TS sample for listByParent. |
| sdk/monitor/arm-monitorslis/samples/v1-beta/javascript/package.json | JS samples package manifest. |
| sdk/monitor/arm-monitorslis/samples/v1-beta/javascript/README.md | JS samples README. |
| sdk/monitor/arm-monitorslis/samples/v1-beta/javascript/sample.env | JS samples env template. |
| sdk/monitor/arm-monitorslis/samples/v1-beta/javascript/slisCreateOrUpdateSample.js | JS sample for createOrUpdate. |
| sdk/monitor/arm-monitorslis/samples/v1-beta/javascript/slisDeleteSample.js | JS sample for delete. |
| sdk/monitor/arm-monitorslis/samples/v1-beta/javascript/slisGetSample.js | JS sample for get. |
| sdk/monitor/arm-monitorslis/samples/v1-beta/javascript/slisListByParentSample.js | JS sample for listByParent. |
| sdk/monitor/arm-monitorslis/samples-dev/slisCreateOrUpdateSample.ts | Dev sample for createOrUpdate. |
| sdk/monitor/arm-monitorslis/samples-dev/slisDeleteSample.ts | Dev sample for delete. |
| sdk/monitor/arm-monitorslis/samples-dev/slisGetSample.ts | Dev sample for get. |
| sdk/monitor/arm-monitorslis/samples-dev/slisListByParentSample.ts | Dev sample for listByParent. |
| sdk/monitor/arm-monitorslis/review/arm-monitorslis-node.api.md | API Extractor report for main entry. |
| sdk/monitor/arm-monitorslis/review/arm-monitorslis-models-node.api.md | API Extractor report for models entry. |
| sdk/monitor/arm-monitorslis/review/arm-monitorslis-api-node.api.md | API Extractor report for api entry. |
| sdk/monitor/arm-monitorslis/review/arm-monitorslis-api-slis-node.api.md | API Extractor report for api/slis. |
| sdk/monitor/arm-monitorslis/package.json | New package manifest, scripts, deps, exports map. |
| sdk/monitor/arm-monitorslis/metadata.json | Generator metadata and cross-language definitions. |
| sdk/monitor/arm-monitorslis/eslint.config.mjs | Package eslint configuration. |
| sdk/monitor/arm-monitorslis/api-extractor.json | API Extractor config. |
| sdk/monitor/arm-monitorslis/README.md | Package README with snippets. |
| sdk/monitor/arm-monitorslis/LICENSE | Package license file. |
| sdk/monitor/arm-monitorslis/CHANGELOG.md | Initial changelog entry. |
| sdk/monitor/arm-monitorslis/sample.env | Package-level env template. |
| pnpm-lock.yaml | Adds workspace importer entries for the new package. |
| eng/ignore-links.txt | Adds docs.ms + npm links to link-check ignore list. |
| .github/CODEOWNERS | Adds codeowners for sdk/monitor/arm-monitorslis/. |
Files not reviewed (1)
- pnpm-lock.yaml: Language not supported
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Configurations: 'specification/monitoringservice/resource-manager/Microsoft.Monitor/Slis/tspconfig.yaml', and CommitSHA: 'd32a3f6cc49c6dd6604161f8c7cee7c95a84c578' in SpecRepo: 'https://github.com/Azure/azure-rest-api-specs' Pipeline run: https://dev.azure.com/azure-sdk/internal/_build/results?buildId=6195149 Refer to https://eng.ms/docs/products/azure-developer-experience/develop/sdk-release/sdk-release-prerequisites to prepare for SDK release. Release plan link: https://web.powerapps.com/apps/821ab569-ae60-420d-8264-d7b5d5ef734c?release-plan-id=2f8fce48-d33d-f111-88b4-000d3a5b007c Submitted by: Saleel.Kattiyat@microsoft.com
Release Plan Details
Spec pull request: Exclude SloView operations from SDK generation azure-rest-api-specs#42529
Spec API version: