Fix broken Spring compatibility tests #45733
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alzimmermsft
added
EngSys
alzimmermsft
requested review from
rujche,
Netyyyy,
saragluna,
moarychan and
a team
as code owners
There was a problem hiding this comment.
Pull Request Overview
This pull request fixes the broken Spring compatibility tests by adding additional suppression annotations to address deprecation and removal warnings and by updating scripts to read the local supported Spring JSON file rather than fetching it remotely.
- Added "removal" to @SuppressWarnings annotations in several test and configuration files.
- Modified scripts to load the supported Spring versions from a local file, and updated Maven options in pipeline YAML files.
Reviewed Changes
Copilot reviewed 16 out of 16 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| sdk/spring/spring-cloud-azure-autoconfigure/src/test/java/com/azure/spring/cloud/autoconfigure/implementation/aadb2c/configuration/WebOAuth2ClientTestApp.java | Added suppression for "removal" warning. |
| sdk/spring/spring-cloud-azure-autoconfigure/src/test/java/com/azure/spring/cloud/autoconfigure/implementation/aad/configuration/AadOAuth2ClientConfigurationTests.java | Updated suppression to include "removal". |
| sdk/spring/spring-cloud-azure-autoconfigure/src/main/java/com/azure/spring/cloud/autoconfigure/implementation/aadb2c/security/AadB2cOidcLoginConfigurer.java | Updated suppression to include "removal". |
| sdk/spring/spring-cloud-azure-autoconfigure/src/main/java/com/azure/spring/cloud/autoconfigure/implementation/aadb2c/security/AadB2cAuthorizationRequestResolver.java | Added suppression for "removal" warning. |
| sdk/spring/spring-cloud-azure-autoconfigure/src/main/java/com/azure/spring/cloud/autoconfigure/implementation/aad/configuration/AadOAuth2ClientConfiguration.java | Updated multiple suppression annotations to include "removal". |
| sdk/spring/spring-cloud-azure-autoconfigure/src/main/java/com/azure/spring/cloud/autoconfigure/implementation/aad/security/AbstractOAuth2AuthorizationCodeGrantRequestEntityConverter.java | Updated suppression to include "removal". |
| sdk/spring/spring-cloud-azure-autoconfigure/src/main/java/com/azure/spring/cloud/autoconfigure/implementation/aad/security/AadWebApplicationHttpSecurityConfigurer.java | Updated suppression to include "removal". |
| sdk/spring/spring-cloud-azure-autoconfigure/src/main/java/com/azure/spring/cloud/autoconfigure/implementation/aad/security/AadJwtBearerGrantRequestEntityConverter.java | Updated suppression to include "removal". |
| sdk/spring/scripts/monitor_update_monitor_matrix_json.py | Changed file retrieval from an HTTP request to local file reading. |
| sdk/spring/scripts/compatibility_update_supported_version_matrix_json.py | Changed file retrieval from HTTP request to local file read. |
| sdk/spring/scripts/compatibility_get_spring_cloud_version.py | Modified file fetching to read from a local file. |
| sdk/spring/pipeline/monitor-tests-job.yml | Updated Maven options to include "--fail-at-end" and added logging options. |
| sdk/spring/pipeline/compatibility-tests-job.yml | Updated Maven options to include "--fail-at-end" and logging options. |
| sdk/spring/azure-spring-data-cosmos/src/main/java/com/azure/spring/data/cosmos/repository/support/ReactiveCosmosRepositoryFactory.java | Updated suppression annotations to include "removal". |
| sdk/spring/azure-spring-data-cosmos/src/main/java/com/azure/spring/data/cosmos/repository/support/CosmosRepositoryFactory.java | Updated suppression annotations to include "removal". |
Netyyyy
reviewed
Jun 18, 2025
...s/src/main/java/com/azure/spring/data/cosmos/repository/support/CosmosRepositoryFactory.java
Show resolved
Hide resolved
|
@Netyyyy the PR should be in a good state to merge as it makes the script work better and fixes compilation issues. There are still test failures, but I don't know the code well enough to fix them. Should I file an issue for the Spring SDK owners to follow up on? |
API Change CheckAPIView identified API level changes in this PR and created the following API reviews |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #45602
Adds additional suppression to
azure-spring-data-cosmosto suppression a deprecation for removal warning.Fixes script that generates the compatibility test matrix to use the source version of
spring-cloud-azure-supported-spring.jsonrather than the one committed to the main branch. This fix would have prevented the broken change inazure-spring-data-cosmosfrom being merged to main.All SDK Contribution checklist:
General Guidelines and Best Practices
Testing Guidelines