Skip to content

[eventgrid] Latest re-generation for namespace #45625

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from

Conversation

samvaity
Copy link
Member

@samvaity samvaity commented Jun 6, 2025

Description

Only internal implementation improvements for namespaces library based on Add visibility read to response collection properties by JoshLove-msft · Pull Request #34128 · Azure/azure-rest-api-specs

@samvaity samvaity changed the title [eventgrid] Latest generation for namespace [eventgrid] Latest re-generation for namespace Jun 6, 2025
@samvaity samvaity changed the title [eventgrid] Latest re-generation for namespace [eventgrid] Latest re-generation for namespace Jun 6, 2025
@samvaity samvaity marked this pull request as ready for review June 6, 2025 20:36
@Copilot Copilot AI review requested due to automatic review settings June 6, 2025 20:36
@samvaity samvaity requested review from srnagar, lmolkova and a team as code owners June 6, 2025 20:36
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates internal implementations in the namespaces library for EventGrid by re‐generating several model classes and updating the YAML configuration for the API specification.

  • Updated the commit reference and added an "additionalDirectories" key in tsp-location.yaml.
  • Modified several JSON-serializable model classes (RenewLocksResult, ReleaseResult, RejectResult, ReceiveResult, and AcknowledgeResult) to use mutable fields and a default constructor for deserialization while removing array field serialization in toJson.

Reviewed Changes

Copilot reviewed 6 out of 6 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
sdk/eventgrid/azure-messaging-eventgrid-namespaces/tsp-location.yaml Updated commit hash; added "additionalDirectories" key without a defined value.
sdk/eventgrid/azure-messaging-eventgrid-namespaces/src/main/java/com/azure/messaging/eventgrid/namespaces/models/RenewLocksResult.java Transitioned from immutable fields and parameterized constructor to mutable fields with default constructor; removed writing of array fields in toJson.
sdk/eventgrid/azure-messaging-eventgrid-namespaces/src/main/java/com/azure/messaging/eventgrid/namespaces/models/ReleaseResult.java Similar changes as in RenewLocksResult with mutable fields and default constructor; removed serialization of fields in toJson.
sdk/eventgrid/azure-messaging-eventgrid-namespaces/src/main/java/com/azure/messaging/eventgrid/namespaces/models/RejectResult.java Same pattern as above with updates to deserialization and toJson methods.
sdk/eventgrid/azure-messaging-eventgrid-namespaces/src/main/java/com/azure/messaging/eventgrid/namespaces/models/ReceiveResult.java Modified field declaration and removed serialization of details in toJson.
sdk/eventgrid/azure-messaging-eventgrid-namespaces/src/main/java/com/azure/messaging/eventgrid/namespaces/models/AcknowledgeResult.java Updated to use mutable fields and default constructor; toJson no longer serializes its fields.
Comments suppressed due to low confidence (5)

sdk/eventgrid/azure-messaging-eventgrid-namespaces/src/main/java/com/azure/messaging/eventgrid/namespaces/models/RenewLocksResult.java:61

  • The toJson method no longer writes the 'failedLockTokens' and 'succeededLockTokens' arrays. This removal can lead to missing data in the JSON output.
jsonWriter.writeStartObject();

sdk/eventgrid/azure-messaging-eventgrid-namespaces/src/main/java/com/azure/messaging/eventgrid/namespaces/models/ReleaseResult.java:59

  • The toJson method no longer serializes the 'failedLockTokens' and 'succeededLockTokens' fields, which may result in incomplete JSON representation.
jsonWriter.writeStartObject();

sdk/eventgrid/azure-messaging-eventgrid-namespaces/src/main/java/com/azure/messaging/eventgrid/namespaces/models/RejectResult.java:59

  • The removal of the serialization lines for 'failedLockTokens' and 'succeededLockTokens' in toJson may lead to incomplete JSON output.
jsonWriter.writeStartObject();

sdk/eventgrid/azure-messaging-eventgrid-namespaces/src/main/java/com/azure/messaging/eventgrid/namespaces/models/ReceiveResult.java:43

  • The toJson method omits the serialization of the 'details' array (previously written as the 'value' field), which can result in data loss during JSON conversion.
jsonWriter.writeStartObject();

sdk/eventgrid/azure-messaging-eventgrid-namespaces/src/main/java/com/azure/messaging/eventgrid/namespaces/models/AcknowledgeResult.java:59

  • The toJson method no longer serializes the 'failedLockTokens' and 'succeededLockTokens' fields, potentially causing incomplete JSON representations.
jsonWriter.writeStartObject();

@samvaity samvaity closed this Jun 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant