Update OpenAIClientBuilder.java to be able to handle all non-azure endpoints #45074
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…dpoints Currently the only way to acquire a NonAzureOpenAIClient, which can interact with any endpoint designed to take OpenAI-api-like HTTP requests, is to pass no endpoint at all or to pass an endpoint starting with "https://api.openai.com/". An option to specify whether you want a NonAzure client or not would be appreciated.
seannie2
requested review from
brandom-msft,
jpalvarezl and
mssfang
as code owners
github-actions
bot
added
Community Contribution
|
Thank you for your contribution @seannie2! We will review the pull request and get back to you soon. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Currently the only way to acquire a NonAzureOpenAIClient, which can interact with any endpoint designed to take OpenAI-api-like HTTP requests, is to pass no endpoint at all, or to pass an endpoint starting with "https://api.openai.com/".
A builder option to explicitly specify whether you want a NonAzure client or not would be appreciated.
This PR adds a
nonAzureClient()method to theOpenAIClientBuilderRelated:
#43228 #41438
If an SDK is being regenerated based on a new swagger spec, a link to the pull request containing these swagger spec changes has been included above.
All SDK Contribution checklist:
General Guidelines and Best Practices
Testing Guidelines