-
Notifications
You must be signed in to change notification settings - Fork 2.1k
[DO NOT MERGE] Upgrade Reactor and Reactor Netty dependencies #43367
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
/azp run java - core |
|
/azp run java - spring |
|
Azure Pipelines successfully started running 1 pipeline(s). |
1 similar comment
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run java - spring - tests |
|
/azp run java - cosmos - tests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
1 similar comment
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
I assume the upgrade is to be merged after BOM release? |
|
Hi, |
|
Yes, please pick this up again and bump Netty Reactor to the fixed version. Looking at this PR and the current version being |
|
reactor-netty-http upgrade to 1.2.8 is breaking the webclient calls. It is working till 1.2.7. |
|
@nehapawar9 You need also to update Netty to at least version 4.1.122.Final |
Yes, there were CVEs reported for some of the older 4.1 versions. Just a heads up: Netty 4.2 changed some defaults, e.g. for the hostname verification. |
|
Hi! There's a fix version 1.0.49 but it seems it's only available in the spring commercial license. Is there a way to update and use that one? |
|
Can this be closed in favor of the already merged #46207? |
|
Closing as this work was done in #46207 |
Description
This PR is upgrading Reactor dependencies from
3.4.41to3.7.1and Reactor Netty from1.0.48to1.2.1. This is being done as the previous Reactor and Reactor Netty minor versions,3.4.xand1.0.xrespectively, are end of life and no longer receiving updates.The Azure SDKs will continue to perform version validation tests using Reactor versions
3.4.15,3.5.0, and3.6.0and Reactor Netty versions1.0.0and1.1.0to ensure a baseline compatibility with common ecosystems such as Spring which leverage Reactor as well.Looking forward into the future, eventually validation for Reactor
3.4.15and Reactor Netty1.0.0can be dropped once Spring Framework 5.3 and Spring Boot 2.7 reach end of life for commercial support.And possibly other versions could be dropped as well depending on ecosystem support for them in maintained versions.
All SDK Contribution checklist:
General Guidelines and Best Practices
Testing Guidelines