Skip to content

Add csharp customizations for ServiceGroups migration#42596

Open
meghanagupta95 wants to merge 2 commits intoAzure:mainfrom
meghanagupta95:servicegroups-csharp-customizations
Open

Add csharp customizations for ServiceGroups migration#42596
meghanagupta95 wants to merge 2 commits intoAzure:mainfrom
meghanagupta95:servicegroups-csharp-customizations

Conversation

@meghanagupta95
Copy link
Copy Markdown
Member

Add C#-scoped @@clientName decorators to client.tsp for the Azure.ResourceManager.ServiceGroups SDK migration from Swagger to TypeSpec.

Decorators added

Decorator Purpose
@@clientName(ProvisioningState, "ServiceGroupProvisioningState", "csharp") Match existing SDK naming
@@clientName(ServiceGroups, "ServiceGroupClient", "csharp") Avoid C# namespace-type name conflict
@@clientName(ServiceGroupCollectionResponse, "ServiceGroupCollectionResult", "csharp") AZC0030 compliance

Related SDK PR

Azure/azure-sdk-for-net#58532

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Apr 23, 2026

Next Steps to Merge

Next steps that must be taken to merge this PR:
  • ❌ This PR targets either the main branch of the public specs repo or the RPSaaSMaster branch of the private specs repo. These branches are not intended for iterative development. Therefore, you must acknowledge you understand that after this PR is merged, the APIs are considered shipped to Azure customers. Any further attempts at in-place modifications to the APIs will be subject to Azure's versioning and breaking change policies. Additionally, for control plane APIs, you must acknowledge that you are following all the best practices documented by ARM at aka.ms/armapibestpractices. If you do intend to release the APIs to your customers by merging this PR, add the PublishToCustomers label to your PR in acknowledgement of the above. Otherwise, retarget this PR onto a feature branch, i.e. with prefix release- (see aka.ms/azsdk/api-versions#release--branches).
  • ❌ This PR is in purview of the ARM review (label: ARMReview). This PR must get ARMSignedOff label from an ARM reviewer.
    This PR is awaiting ARM reviewer feedback (label: WaitForARMFeedback).
    To learn when this PR will get reviewed, see ARM review queue at aka.ms/azsdk/pr-arm-review
    For details of the ARM review, see aka.ms/azsdk/pr-arm-review
  • ❌ The required check named TypeSpec Requirement has failed. Refer to the check in the PR's 'Checks' tab for details on how to fix it and consult the aka.ms/ci-fix guide
  • ❌ The required check named SDK Validation Status has failed. Refer to the check in the PR's 'Checks' tab for details on how to fix it and consult the aka.ms/ci-fix guide


Comment generated by summarize-checks workflow run.

Add C#-scoped @@clientName decorators to client.tsp for the
Azure.ResourceManager.ServiceGroups SDK migration from Swagger to TypeSpec:

- Rename ProvisioningState to ServiceGroupProvisioningState (match existing SDK)
- Rename ServiceGroups interface to ServiceGroupClient (avoid namespace conflict)
- Rename ServiceGroupCollectionResponse to ServiceGroupCollectionResult (AZC0030)

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@meghanagupta95 meghanagupta95 force-pushed the servicegroups-csharp-customizations branch from ff17352 to 57a67bf Compare April 23, 2026 01:11
@meghanagupta95 meghanagupta95 marked this pull request as ready for review April 23, 2026 01:13
@github-actions github-actions Bot added ARMReview WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required and removed ARMReview labels Apr 23, 2026
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Apr 23, 2026

API Change Check

APIView identified API level changes in this PR and created the following API reviews

Language API Review for Package
TypeSpec Microsoft.Management
Go sdk/resourcemanager/servicegroups/armservicegroups

Comment generated by After APIView workflow run.

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Note

Copilot was unable to run its full agentic suite in this review.

Adds C#-specific naming customizations in the TypeSpec client definition to support the Azure.ResourceManager.ServiceGroups migration and align generated C# naming with existing SDK conventions and analyzer rules.

Changes:

  • Add @@clientName for ProvisioningState to match existing C# SDK naming.
  • Add @@clientName for ServiceGroups to avoid a C# namespace/type name collision.
  • Add @@clientName for ServiceGroupCollectionResponse to comply with AZC0030.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ARMReview resource-manager TypeSpec Authored with TypeSpec WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants