Add csharp customizations for ServiceGroups migration#42596
Open
meghanagupta95 wants to merge 2 commits intoAzure:mainfrom
Open
Add csharp customizations for ServiceGroups migration#42596meghanagupta95 wants to merge 2 commits intoAzure:mainfrom
meghanagupta95 wants to merge 2 commits intoAzure:mainfrom
Conversation
Next Steps to MergeNext steps that must be taken to merge this PR:
Comment generated by summarize-checks workflow run. |
Add C#-scoped @@clientName decorators to client.tsp for the Azure.ResourceManager.ServiceGroups SDK migration from Swagger to TypeSpec: - Rename ProvisioningState to ServiceGroupProvisioningState (match existing SDK) - Rename ServiceGroups interface to ServiceGroupClient (avoid namespace conflict) - Rename ServiceGroupCollectionResponse to ServiceGroupCollectionResult (AZC0030) Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
ff17352 to
57a67bf
Compare
API Change CheckAPIView identified API level changes in this PR and created the following API reviews
Comment generated by After APIView workflow run. |
Contributor
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
Adds C#-specific naming customizations in the TypeSpec client definition to support the Azure.ResourceManager.ServiceGroups migration and align generated C# naming with existing SDK conventions and analyzer rules.
Changes:
- Add
@@clientNameforProvisioningStateto match existing C# SDK naming. - Add
@@clientNameforServiceGroupsto avoid a C# namespace/type name collision. - Add
@@clientNameforServiceGroupCollectionResponseto comply with AZC0030.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add C#-scoped
@@clientNamedecorators toclient.tspfor theAzure.ResourceManager.ServiceGroupsSDK migration from Swagger to TypeSpec.Decorators added
@@clientName(ProvisioningState, "ServiceGroupProvisioningState", "csharp")@@clientName(ServiceGroups, "ServiceGroupClient", "csharp")@@clientName(ServiceGroupCollectionResponse, "ServiceGroupCollectionResult", "csharp")Related SDK PR
Azure/azure-sdk-for-net#58532