Skip to content

adding service-name segment for fixing routing for partial RP#42592

Open
hardikginwala wants to merge 10 commits intoAzure:mainfrom
hardikginwala:fixroutingForBACallsOnCompute
Open

adding service-name segment for fixing routing for partial RP#42592
hardikginwala wants to merge 10 commits intoAzure:mainfrom
hardikginwala:fixroutingForBACallsOnCompute

Conversation

@hardikginwala
Copy link
Copy Markdown
Contributor

@hardikginwala hardikginwala commented Apr 22, 2026

ARM (Control Plane) API Specification Update Pull Request

Tip

Overwhelmed by all this guidance? See the Getting help section at the bottom of this PR description.

PR review workflow diagram

Please understand this diagram before proceeding. It explains how to get your PR approved & merged.

spec_pr_review_workflow_diagram

Purpose of this PR

What's the purpose of this PR? Check the specific option that applies. This is mandatory!

  • New resource provider.
  • New API version for an existing resource provider. (If API spec is not defined in TypeSpec, the PR should have been created in adherence to OpenAPI specs PR creation guidance).
  • Update existing version for a new feature. (This is applicable only when you are revising a private preview API version.)
  • Update existing version to fix OpenAPI spec quality issues in S360.
  • Convert existing OpenAPI spec to TypeSpec spec (do not combine this with implementing changes for a new API version).
  • Other, please clarify:
    • updating route to address a routing issue on ARM

Due diligence checklist

To merge this PR, you must go through the following checklist and confirm you understood
and followed the instructions by checking all the boxes:

  • I confirm this PR is modifying Azure Resource Manager (ARM) related specifications, and not data plane related specifications.
  • I have reviewed following Resource Provider guidelines, including
    ARM resource provider contract and
    REST guidelines (estimated time: 4 hours).
    I understand this is required before I can proceed to the diagram Step 2, "ARM API changes review", for this PR.
  • A release plan has been created. If not, please create one as it will help guide you through the REST API and SDK creation process.

Additional information

This PR is a quick follow up to fix an issue discovered during testing of this recently merged PR

Notes for ARM reviewer

  • ✅ Service behavior unchanged
  • ✅ This PR fixes an incorrect spec definition
  • ✅ No customer-visible breaking change

These changes have not been shipped to customer yet, no SDK has been generated, so there is no impact on end user as result of this same version change.

Viewing API changes

For convenient view of the API changes made by this PR, refer to the URLs provided in the table
in the Generated ApiView comment added to this PR. You can use ApiView to show API versions diff.

Suppressing failures

If one or multiple validation error/warning suppression(s) is detected in your PR, please follow the
suppressions guide to get approval.

Getting help

  • First, please carefully read through this PR description, from top to bottom. Please fill out the Purpose of this PR and Due diligence checklist.
  • If you don't have permissions to remove or add labels to the PR, request write access per aka.ms/azsdk/access#request-access-to-rest-api-or-sdk-repositories
  • To understand what you must do next to merge this PR, see the Next Steps to Merge comment. It will appear within few minutes of submitting this PR and will continue to be up-to-date with current PR state.
  • For guidance on fixing this PR CI check failures, see the hyperlinks provided in given failure
    and https://aka.ms/ci-fix.
  • For help with ARM review (PR workflow diagram Step 2), see https://aka.ms/azsdk/pr-arm-review.
  • If the PR CI checks appear to be stuck in queued state, please add a comment with contents /azp run.
    This should result in a new comment denoting a PR validation pipeline has started and the checks should be updated after few minutes.
  • If the help provided by the previous points is not enough, post to https://aka.ms/azsdk/support/specreview-channel and link to this PR.
  • For guidance on SDK breaking change review, refer to https://aka.ms/ci-fix.

Co-authored-by: Copilot <copilot@github.com>
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Apr 22, 2026

Next Steps to Merge

Next steps that must be taken to merge this PR:
  • ❌ This PR is in purview of the ARM review (label: ARMReview). This PR must get ARMSignedOff label from an ARM reviewer.
    This PR is awaiting ARM reviewer feedback (label: WaitForARMFeedback).
    To learn when this PR will get reviewed, see ARM review queue at aka.ms/azsdk/pr-arm-review
    For details of the ARM review, see aka.ms/azsdk/pr-arm-review


Comment generated by summarize-checks workflow run.

@hardikginwala hardikginwala added Versioning-Approved-BugFix https://github.com/Azure/azure-sdk-tools/issues/6374 PublishToCustomers Acknowledgement the changes will be published to Azure customers. labels Apr 22, 2026
@github-actions github-actions Bot added ARMReview resource-manager TypeSpec Authored with TypeSpec WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required VersioningReviewRequired <valid label in PR review process>add this label when versioning review is required labels Apr 22, 2026
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Apr 22, 2026

API Change Check

APIView identified API level changes in this PR and created the following API reviews

Language API Review for Package
Swagger Microsoft.Compute-Bulkactions
TypeSpec Microsoft.Compute
Go sdk/resourcemanager/compute/armbulkactions
JavaScript @azure/arm-computebulkactions
Java com.azure.resourcemanager:azure-resourcemanager-compute-bulkactions

Comment generated by After APIView workflow run.

@hardikginwala hardikginwala changed the title adding segment for BA in route adding service-name segment for fixing routing for partial RP Apr 23, 2026
@hardikginwala hardikginwala marked this pull request as ready for review April 23, 2026 02:33
@hardikginwala hardikginwala requested a review from Copilot April 23, 2026 03:47
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the Microsoft.Compute Bulkactions TypeSpec routing to change the location-scoped bulk VM operation path shape (adding a bulkVmOperations segment as the first segment after locations/{location}) and aligns generated OpenAPI + suppressions/examples accordingly.

Changes:

  • Updated the TypeSpec route composition for bulk VM actions to emit /locations/{location}/bulkVmOperations/virtualMachines/....
  • Removed the previously-specified GET endpoint for the singleton bulk VM operations proxy resource (and removed its schema + examples).
  • Updated readme.md suppressions to match the new generated paths.

Reviewed changes

Copilot reviewed 7 out of 7 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
specification/compute/resource-manager/Microsoft.Compute/Bulkactions/routes.tsp Adjusts the static path segments used by bulk VM action routes and removes the GET endpoint from the interface.
specification/compute/resource-manager/Microsoft.Compute/Bulkactions/readme.md Updates linter suppression where paths to match the new route shape; removes the suppression tied to the deleted GET endpoint.
specification/compute/resource-manager/Microsoft.Compute/Bulkactions/preview/2026-04-06-preview/Bulkactions.json Regenerated swagger reflecting the new route shape and the removal of the GET endpoint + its schema.
specification/compute/resource-manager/Microsoft.Compute/Bulkactions/preview/2026-04-06-preview/examples/VirtualMachineBulkOperations_BulkVmOperations_MinimumSet_Gen.json Removes example for the deleted GET endpoint.
specification/compute/resource-manager/Microsoft.Compute/Bulkactions/preview/2026-04-06-preview/examples/VirtualMachineBulkOperations_BulkVmOperations_MaximumSet_Gen.json Removes example for the deleted GET endpoint.
specification/compute/resource-manager/Microsoft.Compute/Bulkactions/examples/2026-04-06-preview/VirtualMachineBulkOperations_BulkVmOperations_MinimumSet_Gen.json Removes example for the deleted GET endpoint (source examples folder).
specification/compute/resource-manager/Microsoft.Compute/Bulkactions/examples/2026-04-06-preview/VirtualMachineBulkOperations_BulkVmOperations_MaximumSet_Gen.json Removes example for the deleted GET endpoint (source examples folder).

Comment thread specification/compute/resource-manager/Microsoft.Compute/Bulkactions/routes.tsp Outdated
Comment thread specification/compute/resource-manager/Microsoft.Compute/Bulkactions/routes.tsp Outdated
Co-authored-by: Copilot <copilot@github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ARMReview Compute PublishToCustomers Acknowledgement the changes will be published to Azure customers. resource-manager SuppressionReviewRequired TypeSpec Authored with TypeSpec Versioning-Approved-BugFix https://github.com/Azure/azure-sdk-tools/issues/6374 VersioningReviewRequired <valid label in PR review process>add this label when versioning review is required WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants