Skip to content

Fix 2026-04-01 GA scope: Remove ingestionPermissionOptions from KnowledgeSourceIngestionParameters#42579

Open
yangylu91 wants to merge 2 commits intomainfrom
search-2026-04-01/remove-ingestionPermissionOptions
Open

Fix 2026-04-01 GA scope: Remove ingestionPermissionOptions from KnowledgeSourceIngestionParameters#42579
yangylu91 wants to merge 2 commits intomainfrom
search-2026-04-01/remove-ingestionPermissionOptions

Conversation

@yangylu91
Copy link
Copy Markdown
Member

@yangylu91 yangylu91 commented Apr 22, 2026

This PR fixes the 2026-04-01 (GA) scope by removing ingestionPermissionOptions from KnowledgeSourceIngestionParameters.

We previously removed other permission-related properties/models (e.g. indexerPermissionOptions) tied to content security features from 2026-04-01 (GA) but missed this one. Since 2026-04-01 GA does not support x-ms-query-source-authorization on the query side, ingestion permission options should not be exposed either; this change fully removes the ingestion-permission surface everywhere it appears (spec and examples) to keep the GA contract consistent.

@yangylu91 yangylu91 changed the title Fix 2026-04-01 GA scope: Remove ingestionPermissionOptions from Knowl… Fix 2026-04-01 GA scope: Remove ingestionPermissionOptions from KnowledgeSourceIngestionParameters Apr 22, 2026
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Apr 22, 2026

Next Steps to Merge

Next steps that must be taken to merge this PR:
  • ❌ This PR has at least one breaking change (label: BreakingChangeReviewRequired).
    To unblock this PR, follow the process at aka.ms/brch.
  • ❌ The required check named Swagger BreakingChange has failed. To unblock this PR, follow the process at aka.ms/brch.


Comment generated by summarize-checks workflow run.

@github-actions github-actions Bot added data-plane TypeSpec Authored with TypeSpec BreakingChangeReviewRequired <valid label in PR review process>add this label when breaking change review is required labels Apr 22, 2026
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Apr 22, 2026

API Change Check

APIView identified API level changes in this PR and created the following API reviews

Language API Review for Package
Swagger Search-Search
TypeSpec Search
Python azure-search-documents
JavaScript @azure/search-documents
Java com.azure:azure-search-documents
C# Azure.Search.Documents

Comment generated by After APIView workflow run.

@yangylu91 yangylu91 added the PublishToCustomers Acknowledgement the changes will be published to Azure customers. label Apr 22, 2026
@yangylu91 yangylu91 marked this pull request as ready for review April 22, 2026 18:42
@vaishalishah11
Copy link
Copy Markdown

Looks good to me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

BreakingChangeReviewRequired <valid label in PR review process>add this label when breaking change review is required data-plane PublishToCustomers Acknowledgement the changes will be published to Azure customers. Search TypeSpec Authored with TypeSpec

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants