-
Notifications
You must be signed in to change notification settings - Fork 105
Add basic support for automation #332
base: master
Are you sure you want to change the base?
Conversation
|
|
||
| protected override AutomationControlType GetAutomationControlTypeCore() | ||
| { | ||
| return AutomationControlType.DataItem; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It should be TreeItem, I think.
I was previously checking automation for Visual Studio PropertyGrid, and it was more behaving as a tree rather than grid.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Row itself should also implement IValueProvider
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
And possible IToggleProvider (since it can be expanded/collapsed)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It should be TreeItem, I think. I was previously checking automation for Visual Studio PropertyGrid, and it was more behaving as a tree rather than grid.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
And possible IToggleProvider (since it can be expanded/collapsed)
|
|
||
| namespace Avalonia.Controls.Automation.Peers; | ||
|
|
||
| public class TreeDataGridCellAutomationPeer : ControlAutomationPeer |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shouldn't cell be a content control automation peer? Or just override GetNameCore
https://github.com/AvaloniaUI/Avalonia/blob/master/src/Avalonia.Controls/Automation/Peers/ContentControlAutomationPeer.cs#L16-L31
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixes: #331
Tasks:
Screenshots: