Support bumper sensors in Gazebo #99
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jacobperron
reviewed
Oct 5, 2022
README.md
Outdated
| $ roslaunch create_bringup joy_teleop.launch [joy_config:=xbox360] | ||
| ``` | ||
|
|
||
| There exists configuration files for the [Xbox 360 wired controller](https://www.amazon.ca/Microsoft-Xbox-360-Wired-Controller/dp/B003ZSN600) and the [Logitech F710 controller](http://gaming.logitech.com/en-ca/product/f710-wireless-gamepad). You can adapt these files for your preferred joystick configuration. | ||
|
|
||
| ## Simulation | ||
|
|
||
| The package `create_gazebo` has a launch file with a minimal simulation example of the Create robots. |
There was a problem hiding this comment.
I have mixed feelings about adding a simulation-specific package. The package is not providing any custom simulation plugins or configuration; it is simply an example launch file and rviz config file. I think it makes more sense to simply move those into create_bringup (which is the package meant for example launch/config files). While I think having the examples are nice, it technically introduces a runtime dependency on Gazebo, which I'd rather avoid.
It might be best to keep these examples in a separate repository.
sasilva1998
changed the title
|
Hi @jacobperron, sorry for the late response and thanks for your comments. I have made the recommended changes. |
jacobperron
approved these changes
May 9, 2023
|
Thanks for the contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
versionincreate_description/urdf/create_base.urdf.xacro.turtlebot3_gazebo.This PR is connected to #76.
Test configuration
ROS version: Noetic