MSD: Restore hidden header to fix notifications/help center panels#109647
Closed
MSD: Restore hidden header to fix notifications/help center panels#109647
Conversation
Hack: render the header with height:0/position:absolute when omnibar is enabled instead of removing it entirely. Removing it (#109517) broke the notifications and help center panels that depend on the header being in the DOM.
Jetpack Cloud Live (direct link)
Automattic for Agencies Live (direct link)
Dashboard Live (dotcom) (direct link)
|
matticbot
added
the
[Status] Needs Review
Contributor
|
This PR modifies the release build for the following Calypso Apps: For info about this notification, see here: PCYsg-OT6-p2
To test WordPress.com changes, run |
| alignment="left" | ||
| spacing={ 0 } | ||
| justify="flex-start" | ||
| style={ style } |
Contributor
There was a problem hiding this comment.
at least we should add inert="true" for better a11y 🙂
Contributor
|
Here is alternative option: #109659 |
4 tasks
Member
Author
|
Closing in favour of #109659 |
github-actions
bot
removed
the
[Status] Needs Review
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related: DOTMSD-1156
Proposed Changes
Hack: instead of removing the header entirely when
dashboard/omnibaris enabled (#109517), render it withheight: 0andposition: absoluteso it's visually hidden but still in the DOM.Why are these changes being made?
Removing the header in #109517 broke the notifications and help center panels — they depend on the header being mounted in the DOM. This is definitely a hack; the proper fix is to decouple those panels from the header, but this unblocks things in the meantime.
Testing Instructions
dashboard/omnibarenabled:dashboard/omnibardisabled: verify the standard dashboard header is unchangedPre-merge Checklist