Skip to content

feat: frontend display of bylines#2469

Merged
leogermani merged 2 commits into
trunkfrom
feat/byline-output
Mar 28, 2025
Merged

feat: frontend display of bylines#2469
leogermani merged 2 commits into
trunkfrom
feat/byline-output

Conversation

@allysonsouza

@allysonsouza allysonsouza commented Mar 27, 2025

Copy link
Copy Markdown
Collaborator

All Submissions:

Changes proposed in this Pull Request:

  • Add a filter to short-circuit the newspack_posted_by() functions if there's a custom byline active.

How to test the changes in this Pull Request:

  1. Make sure that you have the work from feat: frontend display of bylines newspack-plugin#3856
  2. Test the output of bylines in the three scenarios:
    • No custom byline set, coauthors plus activated
    • Custom byline set, coauthors plus activated (post with one or more authors in use into the byline)
    • No custom byline set, coauthors plus deactivated

Other information:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes, as applicable?
  • Have you successfully ran tests with your changes locally?

@allysonsouza allysonsouza marked this pull request as ready for review March 28, 2025 18:23
@allysonsouza allysonsouza requested a review from a team as a code owner March 28, 2025 18:23
@allysonsouza allysonsouza added the [Status] Needs Review The issue or pull request needs to be reviewed label Mar 28, 2025
@github-actions github-actions Bot added [Status] Approved The pull request has been reviewed and is ready to merge and removed [Status] Needs Review The issue or pull request needs to be reviewed labels Mar 28, 2025
@leogermani leogermani merged commit 33137ff into trunk Mar 28, 2025
@leogermani leogermani deleted the feat/byline-output branch March 28, 2025 21:51
@github-actions

Copy link
Copy Markdown

Hey @allysonsouza, good job getting this PR merged! 🎉

Now, the needs-changelog label has been added to it.

Please check if this PR needs to be included in the "Upcoming Changes" and "Release Notes" doc. If it doesn't, simply remove the label.

If it does, please add an entry to our shared document, with screenshots and testing instructions if applicable, then remove the label.

Thank you! ❤️

matticbot pushed a commit that referenced this pull request Apr 4, 2025
# [2.9.0-alpha.1](v2.8.0...v2.9.0-alpha.1) (2025-04-04)

### Bug Fixes

* change content_width function name ([#2470](#2470)) ([9592756](9592756))
* correct appearance of membership discount in Woo ([#2465](#2465)) ([bc3a1f6](bc3a1f6))
* **notice:** fetchpriority notice for images ([#2472](#2472)) ([dfc820b](dfc820b))
* remove deprecated geo-location support ([#2468](#2468)) ([8c8eca8](8c8eca8))

### Features

* frontend display of bylines ([#2469](#2469)) ([33137ff](33137ff))
@matticbot

Copy link
Copy Markdown
Contributor

🎉 This PR is included in version 2.9.0-alpha.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

matticbot pushed a commit that referenced this pull request Apr 14, 2025
# [2.9.0](v2.8.0...v2.9.0) (2025-04-14)

### Bug Fixes

* change content_width function name ([#2470](#2470)) ([9592756](9592756))
* correct appearance of membership discount in Woo ([#2465](#2465)) ([bc3a1f6](bc3a1f6))
* **notice:** fetchpriority notice for images ([#2472](#2472)) ([dfc820b](dfc820b))
* remove deprecated geo-location support ([#2468](#2468)) ([8c8eca8](8c8eca8))

### Features

* frontend display of bylines ([#2469](#2469)) ([33137ff](33137ff))
@matticbot

Copy link
Copy Markdown
Contributor

🎉 This PR is included in version 2.9.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

released on @alpha released [Status] Approved The pull request has been reviewed and is ready to merge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants