Skip to content

fix(android) Unused Plugin registration using Android embedding v1 #338

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
31 changes: 31 additions & 0 deletions .dart_tool/extension_discovery/README.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,31 @@
Extension Discovery Cache
=========================

This folder is used by `package:extension_discovery` to cache lists of
packages that contains extensions for other packages.

DO NOT USE THIS FOLDER
----------------------

* Do not read (or rely) the contents of this folder.
* Do write to this folder.

If you're interested in the lists of extensions stored in this folder use the
API offered by package `extension_discovery` to get this information.

If this package doesn't work for your use-case, then don't try to read the
contents of this folder. It may change, and will not remain stable.

Use package `extension_discovery`
---------------------------------

If you want to access information from this folder.

Feel free to delete this folder
-------------------------------

Files in this folder act as a cache, and the cache is discarded if the files
are older than the modification time of `.dart_tool/package_config.json`.

Hence, it should never be necessary to clear this cache manually, if you find a
need to do please file a bug.
1 change: 1 addition & 0 deletions .dart_tool/extension_discovery/vs_code.json
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
{"version":2,"entries":[{"package":"pdftron_flutter","rootUri":"../","packageUri":"lib/"}]}
2 changes: 1 addition & 1 deletion .dart_tool/version
Original file line number Diff line number Diff line change
@@ -1 +1 @@
3.3.2
3.29.1
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@
import io.flutter.embedding.engine.plugins.activity.ActivityPluginBinding;
import io.flutter.plugin.common.BinaryMessenger;
import io.flutter.plugin.common.MethodChannel;
import io.flutter.plugin.common.PluginRegistry.Registrar;
// import io.flutter.plugin.common.PluginRegistry.Registrar;
import io.flutter.plugin.platform.PlatformViewRegistry;

/**
Expand Down Expand Up @@ -60,12 +60,12 @@ public void onDetachedFromActivity() { }
/**
* Plugin registration using Android embedding v1.
*/
public static void registerWith(Registrar registrar) {
final MethodChannel methodChannel = new MethodChannel(registrar.messenger(), "pdftron_flutter");
methodChannel.setMethodCallHandler(new PluginMethodCallHandler(registrar.messenger(), registrar.activeContext()));
registrar
.platformViewRegistry()
.registerViewFactory(viewTypeId,
new DocumentViewFactory(registrar.messenger(), registrar.activeContext()));
}
// public static void registerWith(Registrar registrar) {
// final MethodChannel methodChannel = new MethodChannel(registrar.messenger(), "pdftron_flutter");
// methodChannel.setMethodCallHandler(new PluginMethodCallHandler(registrar.messenger(), registrar.activeContext()));
// registrar
// .platformViewRegistry()
// .registerViewFactory(viewTypeId,
// new DocumentViewFactory(registrar.messenger(), registrar.activeContext()));
// }
}